Page MenuHomePhabricator
Create Task
Maniphest T308753

FileImporter: Generic error "failed to commit operations" doesn't mention actual reason
Closed, ResolvedPublicBUG REPORT
Actions

Description

FileImporter fails to show detailed error messages in some cases, even if more specific information is available. This happens especially during the "commit" phase (the last of the "prepare" → "validate" → "commit" phases). See T308691#7941603 for a specific example.

The draft in https://gerrit.wikimedia.org/r/793481 shows what's missing.

Instructions when working on the task:

If you need help along the way, feel free to poke @WMDE-Fisch

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Log and show reasons when commit operations failThiemo Kreuz (WMDE)mediawiki/extensions/FileImportermaster+21 -19
Customize query in gerrit

Related Objects

Event Timeline

thiemowmde created this task.May 19 2022, 2:04 PM
gerritbot added a comment.May 19 2022, 2:05 PM

Change 793481 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FileImporter@master] [WIP] Log and show reasons when commit operations fail

https://gerrit.wikimedia.org/r/793481

gerritbot added a project: Patch-For-Review.May 19 2022, 2:05 PM
thiemowmde added a project: good first task.May 19 2022, 2:06 PM
thiemowmde updated the task description. (Show Details)
thiemowmde mentioned this in T308691: Fatal exception of type "CannotCreateActorException" when trying to export file from zhwikibooks to commons.May 19 2022, 2:17 PM
hashar subscribed.May 19 2022, 2:19 PM

Thanks @thiemowmde !

WMDE-Fisch renamed this task from Generic error "failed to commit operations" doesn't mention actual reason to FileImporter: Generic error "failed to commit operations" doesn't mention actual reason.May 20 2022, 8:28 AM
WMDE-Fisch added a project: Wikimedia-Hackathon-2022.
WMDE-Fisch updated the task description. (Show Details)
WMDE-Fisch moved this task from Backlog to Projects for Newcomers! on the Wikimedia-Hackathon-2022 board.
WMDE-Fisch moved this task from Incoming to Backlog on the WMDE-TechWish-Maintenance board.
thiemowmde moved this task from Backlog to Better done by volunteers on the WMDE-TechWish-Maintenance board.Aug 9 2022, 11:54 AM
Kizule mentioned this in T348690: "Failed to commit operations" on Wikimedia Commons while using FileImporter.Oct 11 2023, 8:31 PM
thiemowmde mentioned this in T253008: Bad error formatting after failed import.Oct 26 2023, 9:49 AM
gerritbot added a comment.Oct 30 2023, 6:07 PM

Change 793481 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Log and show reasons when commit operations fail

https://gerrit.wikimedia.org/r/793481

Maintenance_bot removed a project: Patch-For-Review.Oct 30 2023, 6:10 PM
WMDE-Fisch moved this task from Better done by volunteers to Incoming on the WMDE-TechWish-Maintenance board.Nov 2 2023, 2:24 PM
thiemowmde claimed this task.Nov 10 2023, 8:55 AM
thiemowmde moved this task from Incoming to In progress on the WMDE-TechWish-Maintenance board.
thiemowmde edited projects, added: WMDE-TechWish-Maintenance-2023; removed: good first task.
thiemowmde moved this task from Backlog to Done on the WMDE-TechWish-Maintenance-2023 board.
Tobi_WMDE_SW closed this task as Resolved.Nov 21 2023, 9:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits