Page MenuHomePhabricator
Create Task
Maniphest T308816

Remove unused recent change ID parameter from ContentHandler::createDifferenceEngine()
Open, Needs TriagePublic
Actions

Description

$rcid parameter is currently unused but the problem with removing this is it's a breaking change and will break subclasses that override this method.

One way of doing this safely after thinking and exploring about this for a while is to use __call() method since PHP doesn't support method overloading natively.

Extensions currently overriding this method are: EntitySchema, WikiLambda, and examples and MobileFrontend calls the method and passes it a recent change ID argument.

Details

SubjectRepoBranchLines +/-
Remove unused parameter: `rcid` from methodmediawiki/extensions/examplesmaster+7 -4
Content: Remove unused `rcid` arg when creating diff enginemediawiki/extensions/EntitySchemamaster+7 -5
Remove unused parameter `recentChangeId` from methodmediawiki/extensions/WikiLambdamaster+1 -2
specials: Remove unused `rcid` arg to createDiffenceEngine()mediawiki/extensions/MobileFrontendmaster+7 -2
content: Remove unused `rcid` param from ContentHandlermediawiki/coremaster+85 -17
DNM,Poc: This will emit a deprecation warning in CImediawiki/extensions/MobileFrontendmaster+54 -0
Customize query in gerrit

Event Timeline

xSavitar created this task.May 20 2022, 8:16 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2022, 8:16 AM
Maintenance_bot added a project: Abstract Wikipedia team.May 20 2022, 8:29 AM
gerritbot added a comment.May 20 2022, 8:39 AM

Change 793485 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] content: Remove unused `rcid` param from ContentHandler

https://gerrit.wikimedia.org/r/793485

gerritbot added a project: Patch-For-Review.May 20 2022, 8:39 AM
gerritbot added a comment.May 20 2022, 9:41 AM

Change 793486 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/MobileFrontend@master] specials: Remove unused `rcid` arg to createDiffenceEngine()

https://gerrit.wikimedia.org/r/793486

gerritbot added a comment.May 20 2022, 9:42 AM

Change 793487 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/EntitySchema@master] Content: Remove unused `rcid` arg when creating diff engine

https://gerrit.wikimedia.org/r/793487

gerritbot added a comment.May 20 2022, 9:42 AM

Change 793488 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/WikiLambda@master] Remove unused parameter `recentChangeId` from method

https://gerrit.wikimedia.org/r/793488

gerritbot added a comment.May 20 2022, 9:43 AM

Change 793490 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/examples@master] Remove unused parameter: `rcid` from method

https://gerrit.wikimedia.org/r/793490

xSavitar changed the task status from Open to In Progress.May 20 2022, 9:46 AM
gerritbot added a comment.May 20 2022, 12:06 PM

Change 793741 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/MobileFrontend@master] DNM,Poc: This will emit a deprecation warning in CI

https://gerrit.wikimedia.org/r/793741

Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2021-22).May 20 2022, 2:21 PM
Jdlrobson moved this task from Needs Analysis to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from Ready for Development to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdforrester-WMF moved this task from To triage to To triage: Un-phased work on the Abstract Wikipedia team board.May 24 2022, 6:38 PM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Kanbanana-FY-2021-22).May 25 2022, 5:35 PM

@xSavitar please let us know the priority of this task and timeline, so we can make time to review the MobileFrontend change.

gerritbot added a comment.Jun 6 2022, 9:52 AM

Change 793741 abandoned by D3r1ck01:

[mediawiki/extensions/MobileFrontend@master] DNM,Poc: This will emit a deprecation warning in CI

Reason:

https://gerrit.wikimedia.org/r/793741

gerritbot added a comment.Jun 6 2022, 9:53 AM

Change 793485 abandoned by D3r1ck01:

[mediawiki/core@master] content: Remove unused `rcid` param from ContentHandler

Reason:

https://gerrit.wikimedia.org/r/793485

gerritbot added a comment.Jun 6 2022, 9:53 AM

Change 793486 abandoned by D3r1ck01:

[mediawiki/extensions/MobileFrontend@master] specials: Remove unused `rcid` arg to createDiffenceEngine()

Reason:

https://gerrit.wikimedia.org/r/793486

gerritbot added a comment.Jun 6 2022, 9:53 AM

Change 793488 abandoned by D3r1ck01:

[mediawiki/extensions/WikiLambda@master] Remove unused parameter `recentChangeId` from method

Reason:

https://gerrit.wikimedia.org/r/793488

gerritbot added a comment.Jun 6 2022, 9:53 AM

Change 793487 abandoned by D3r1ck01:

[mediawiki/extensions/EntitySchema@master] Content: Remove unused `rcid` arg when creating diff engine

Reason:

https://gerrit.wikimedia.org/r/793487

gerritbot added a comment.Jun 6 2022, 9:54 AM

Change 793490 abandoned by D3r1ck01:

[mediawiki/extensions/examples@master] Remove unused parameter: `rcid` from method

Reason:

https://gerrit.wikimedia.org/r/793490

Maintenance_bot removed a project: Patch-For-Review.Jun 6 2022, 10:31 AM
Jdforrester-WMF moved this task from To triage: Un-phased work to No current plans / External on the Abstract Wikipedia team board.Dec 7 2023, 5:54 PM
Jdforrester-WMF changed the task status from In Progress to Open.Jan 22 2024, 8:09 PM
Jdforrester-WMF subscribed.

Seemingly not In Progress, but is this in fact now Declined?

Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog.Jan 25 2024, 11:36 PM

FYI: I am hoping to remove the related MobileFrontend code in the next 2-3 weeks.

Jdlrobson moved this task from Backlog to Tracking (Temporarily) on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jan 25 2024, 11:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL