Page MenuHomePhabricator

[testwiki-wmf.12] Task counter doesn't reflect correct number of available tasks
Open, In Progress, Needs TriagePublic

Description

Found when testing T303985. The testing was done on cswiki betalabs and testwiki - the issue might be specific to those testing environments. This issue is about the task counter on the SE module on Special:Homepage and on the post-edit dialog.

The underlying issue - the SE (non-structured tasks) are not removed from the feed even if a user has edited it.

  1. In SE module select two task filters - one for a structured task (add image or add link) and another one for a non-structured task.
  2. Go to a suggested article and make an edit. The counter in the post-edit dialog will display correct or incorrect count depending which type of task was edited:
    • if an edit was made on a structured task, the structured edit task will be removed from the feed. The counter will show the number suggested tasks left minus one (CORRECT)
    • if an edit was made on a non-structured task, the article is left in the feed. The total count of available articles will not be changed, but the actual count (when flipping through the tasks) will be minus one.
Post-edit dialog shows that there are total 11 tasks, but the arrow is inactive
Screen Shot 2022-05-20 at 12.44.54 PM.png (874×1 px, 283 KB)
The end of the feed is reached (the warning is displayed), but the counter shows that there is another task
Screen Shot 2022-05-20 at 12.52.19 PM.png (1×1 px, 108 KB)

Notes:

  • This is a known issue. The impact is more noticeable since the post-edit dialog presents the unchanged count of suggested tasks.
  • The counter behavior (the mismatch between the total count and what's actually available) might be viewed not only as confusing but as an un-addressed bug.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova renamed this task from [testwiki-wmf.12] Task counter doesn't reflect correct number of tasks to [testwiki-wmf.12] Task counter doesn't reflect correct number of available tasks.May 20 2022, 9:00 PM

Change 809967 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: adjust the number of tasks shown in the taskfeed pager to match the total number of tasks received

https://gerrit.wikimedia.org/r/809967

Sgs reopened this task as In Progress.Jun 30 2022, 12:22 PM
Sgs claimed this task.

Re-opening for facilitating the testing of T308008: Number of "found articles" is not matching the real number of articles since the use cases mentioned here should be fixed as well by the patc there ( gerrit 809967 ).

Sgs edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
Sgs moved this task from Incoming to In Progress on the Growth-Team (Current Sprint) board.
Sgs moved this task from In Progress to Code Review on the Growth-Team (Current Sprint) board.

Change 809967 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: adjust the number of tasks shown in the taskfeed pager to match the total number of tasks received

https://gerrit.wikimedia.org/r/809967

Checked in cswiki betalabs - there are several issues with the counter - in task type dialog box, in the SE card and the post-edit dialog. I filed it as T312686: [betalabs] Suggested edits - the counter discrepancies (the issues might be specific to the state of betalabs env).

I checked on testwiki wmf.21 and, as far as I could see, t**he issue is not present if the number of fetched tasks in the post-edit dialog is less than 21.

The issue is still present if the number of fetched task is larger. The link to the screen recording (made on testwiki wmf.21) - https://drive.google.com/file/d/1_hx3AfBSeKK-xSUQGwIrrJV38DuYXxpB/view?usp=sharing.

The screen recording shows several discrepancies but the most important issue is that the articles counted above 40, cannot be fetched and the post-edit dialog navigational arrows (and the counter) display confusing information.

Here is the description of what is happening in the screen recording:

  • the initial number of fetched tasks is 61 on Special:Homepage (disregard the discrepancy by 1 when the filter selection is confirmed)
  • the first edited article is Add link (structured task) article - the post-edit dialog shows 59 articles available.
  • the second edited article Update articles (non-structured task) article - the post-edit dialog shows 59 articles available again.

-After publishing the edit in the second article, I'm going through the suggested articles in the dialog. When I come to the 40 of 59 suggestions, the next suggestion (the 41st) is not shown. Instead there is "End of 29 suggestions" message . The navigational right arrow is still displayed as active, but it's non-clickable.

  • returning to Special:Homepage via "View all suggested edits" will display "1 of 61 suggestions" as it was before.