Page MenuHomePhabricator

leave the generate_family_file.py script gracefully if KeyboardInterrupt occurs during url input is requested
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce:

  • run pwb generate_family_file
  • press ctrl-C when Please insert URL to wiki: was asked

What happens?:

C:\temp>pwb generate_family_file
Please insert URL to wiki: Traceback (most recent call last):
  File "C:\Python310\Scripts\pwb-script.py", line 33, in <module>
    sys.exit(load_entry_point('pywikibot==7.4.0.dev0', 'console_scripts', 'pwb')())
  File "C:\Python310\lib\site-packages\pywikibot\scripts\pwb.py", line 482, in run
    if not execute():
  File "C:\Python310\lib\site-packages\pywikibot\scripts\pwb.py", line 454, in execute
    run_python_file(filename, script_args, module)
  File "C:\Python310\lib\site-packages\pywikibot\scripts\pwb.py", line 143, in run_python_file
    exec(compile(source, filename, 'exec', dont_inherit=True),
  File "C:\Python310\lib\site-packages\pywikibot\scripts\generate_family_file.py", line 297, in <module>
    main()
  File "C:\Python310\lib\site-packages\pywikibot\scripts\generate_family_file.py", line 293, in main
    FamilyFileGenerator(*sys.argv[1:]).run()
  File "C:\Python310\lib\site-packages\pywikibot\scripts\generate_family_file.py", line 133, in run
    if not self.get_params():
  File "C:\Python310\lib\site-packages\pywikibot\scripts\generate_family_file.py", line 94, in get_params
    self.base_url = input('Please insert URL to wiki: ')
KeyboardInterrupt
CRITICAL: Exiting due to uncaught exception <class 'KeyboardInterrupt'>
^C
C:\temp>

What should have happened instead?:
The script should leave in the same way as an empty url does:

C:\temp>pwb generate_family_file
Please insert URL to wiki:

Event Timeline

Xqt triaged this task as Low priority.May 21 2022, 12:52 PM

Change 794549 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] Ingnore KeyboardInterrupt in FamilyFileGenerator.get_params()

https://gerrit.wikimedia.org/r/794549

Change 794549 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] Ignore KeyboardInterrupt in FamilyFileGenerator.get_params()

https://gerrit.wikimedia.org/r/794549