Page MenuHomePhabricator
Create Task
Maniphest T308941

Klaxon redirects to http://klaxon.wikimedia.org (not https)
Closed, ResolvedPublic
Actions

Description

After sending a manual page with Klaxon, it redirects you to the front page. However that redirect happens with the http protocol (not https), so users with strict https mode enabled on their browser might end up on a warning page instead of the actual klaxon front page. It's also unclear to the user if the page went through or not.

Details

ProjectBranchLines +/-Subject
operations/software/klaxonmaster+5 -0Use ProxyFix middleware to recognize HTTPS usage, attempt #2
operations/software/klaxonmaster+2 -0Use ProxyFix middleware to correctly recognize HTTPS usage
Customize query in gerrit

Event Timeline

• taavi created this task.May 21 2022, 7:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 21 2022, 7:19 PM
RhinosF1 added a subscriber: RhinosF1.May 21 2022, 7:22 PM
Legoktm claimed this task.May 21 2022, 8:03 PM
gerritbot added a comment.May 21 2022, 8:12 PM

Change 794759 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/software/klaxon@master] Use ProxyFix middleware to correctly recognize HTTPS usage

https://gerrit.wikimedia.org/r/794759

gerritbot added a project: Patch-For-Review.May 21 2022, 8:12 PM
Dzahn added a project: Sustainability (Incident Followup).May 21 2022, 9:04 PM
gerritbot added a comment.Jul 15 2022, 10:08 AM

Change 794759 merged by jenkins-bot:

[operations/software/klaxon@master] Use ProxyFix middleware to correctly recognize HTTPS usage

https://gerrit.wikimedia.org/r/794759

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2022, 10:30 AM
CDanis added a subscriber: CDanis.Jul 15 2022, 7:46 PM

Unfortunately I had to revert the above patch because the necessary middlewear library isn't included in Debian's python3-werkzeug until Bullseye.

gerritbot added a comment.Jul 15 2022, 8:14 PM

Change 814251 had a related patch set uploaded (by CDanis; author: CDanis):

[operations/software/klaxon@master] Use ProxyFix middleware to recognize HTTPS usage, attempt #2

https://gerrit.wikimedia.org/r/814251

gerritbot added a project: Patch-For-Review.Jul 15 2022, 8:14 PM
gerritbot added a comment.Jul 15 2022, 8:20 PM

Change 814251 merged by jenkins-bot:

[operations/software/klaxon@master] Use ProxyFix middleware to recognize HTTPS usage, attempt #2

https://gerrit.wikimedia.org/r/814251

CDanis closed this task as Resolved.Jul 15 2022, 8:27 PM

Thanks to @Legoktm for catching that this was packaged pre-Bullseye under a different name.

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2022, 8:30 PM
lmata added a project: SRE-OnFire.Jul 18 2022, 4:38 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL