Email users on all changes spams exceptions on default config
Closed, ResolvedPublic
Actions

Description

> var_dump($wgUsersNotifiedOnAllChanges);
array(1) {
  [0]=>
  string(0) ""
}

was giving

TypeError: Argument 1 passed to EmailNotification::compose() must implement interface MediaWiki\Mail\UserEmailContact, bool given, called in /srv/mediawiki/w/includes/mail/EmailNotification.php on line 297

https://github.com/miraheze/mediawiki/pull/7044 is my attempt at stopping it.

Details

	Subject	Repo	Branch	Lines +/-
	notifications: prevent log spam when invalid user object listed.	mediawiki/core	REL1_38	+3 -2
	notifications: prevent log spam when invalid user object listed.	mediawiki/core	master	+3 -2

Customize query in gerrit

Event Timeline

RhinosF1 created this task.May 22 2022, 8:08 AM

Restricted Application added projects: Growth-Team, User-RhinosF1, Infrastructure-Foundations. · View Herald TranscriptMay 22 2022, 8:08 AM

Restricted Application added subscribers: Reception123, Aklapper. · View Herald Transcript

RhinosF1 edited projects, added MediaWiki-Email; removed Infrastructure-Foundations, Mail.May 22 2022, 8:09 AM

RhinosF1 claimed this task.May 22 2022, 10:48 AM

RhinosF1 triaged this task as Medium priority.

RhinosF1 added a project: Wikimedia-Hackathon-2022.

RhinosF1 moved this task from Backlog to Hacking Projects on the Wikimedia-Hackathon-2022 board.

Change 795246 had a related patch set uploaded (by RhinosF1; author: RhinosF1):

[mediawiki/core@master] notifications: prevent log spam when invalid user object listed.

https://gerrit.wikimedia.org/r/795246

gerritbot added a project: Patch-For-Review.May 22 2022, 10:49 AM

• mewoph edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.May 26 2022, 10:34 PM

• mewoph moved this task from Incoming to Blocked / Needs work on the Growth-Team (Sprint 0 (Growth Team)) board.

Jdforrester-WMF closed this task as Resolved.Jun 2 2022, 8:08 PM

Maintenance_bot moved this task from Radar to Done on the User-RhinosF1 board.Jun 2 2022, 8:29 PM

Change 795246 merged by jenkins-bot:

[mediawiki/core@master] notifications: prevent log spam when invalid user object listed.

https://gerrit.wikimedia.org/r/795246

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 2 2022, 9:00 PM

Change 802609 had a related patch set uploaded (by Jforrester; author: RhinosF1):

[mediawiki/core@REL1_38] notifications: prevent log spam when invalid user object listed.

https://gerrit.wikimedia.org/r/802609

Change 802609 merged by jenkins-bot: