Page MenuHomePhabricator

PageTriage JavaScript code audit and cleanup
Closed, ResolvedPublic

Description

Tracking the patches for my general audit and attempts to cleanup code, reviews from growth team would be welcome

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 796361 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/PageTriage@master] Javascript cleanup: remove unused `optionsToken` variables

https://gerrit.wikimedia.org/r/796361

Change 796361 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Javascript cleanup: remove unused `optionsToken` variables

https://gerrit.wikimedia.org/r/796361

Change 799392 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/PageTriage@master] Convert styles to LESS and simplify

https://gerrit.wikimedia.org/r/799392

Change 799456 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/PageTriage@master] modules/ext.pageTriage.views.list/ - unhoist javascript variables

https://gerrit.wikimedia.org/r/799456

Change 799457 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/PageTriage@master] Article model: remove unused user_talk_title_url

https://gerrit.wikimedia.org/r/799457

Change 799392 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Convert styles to LESS and simplify

https://gerrit.wikimedia.org/r/799392

Change 799456 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Modules: unhoist javascript variables

https://gerrit.wikimedia.org/r/799456

Change 802116 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/PageTriage@master] Javascript: use bind() to simplify callbacks

https://gerrit.wikimedia.org/r/802116

Change 802827 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/PageTriage@master] JavaScript: general cleanup and simplifications

https://gerrit.wikimedia.org/r/802827

Change 799457 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Article model: remove unused user_talk_title_url

https://gerrit.wikimedia.org/r/799457

kostajh added subscribers: Novem_Linguae, kostajh.

Removing from current sprint as we have too many other items right now. @Novem_Linguae might be interested in these cleanup patches, though?

Change 802116 abandoned by Kosta Harlan:

[mediawiki/extensions/PageTriage@master] Javascript: clean up uses of `that = this`

Reason:

Cleaning up the code review queue; if you intend to work on this more, please restore it.

https://gerrit.wikimedia.org/r/802116

Change 802827 abandoned by Kosta Harlan:

[mediawiki/extensions/PageTriage@master] JavaScript: general cleanup and simplifications

Reason:

Cleaning up the code review queue; if you intend to work on this more, please restore it.

https://gerrit.wikimedia.org/r/802827

Change 802827 restored by Thiemo Kreuz (WMDE):

[mediawiki/extensions/PageTriage@master] JavaScript: general cleanup and simplifications

https://gerrit.wikimedia.org/r/802827

Change 802827 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/PageTriage@master] JavaScript: general cleanup and simplifications

Reason:

Ok, sorry. I tried to rebase this. It's not bad, but there are enough conflicts to make this to complicated for a quick win. There are just to many different changes done in the same patch, I'm afraid. It would be better to redo some of the changes in a series of much smaller patches. Danny, please feel free to do this if you think it's worth our time. I will happily merge such patches.

https://gerrit.wikimedia.org/r/802827

Change 863352 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/PageTriage@master] ext.pageTriage.article.js: general cleanup and simplifications

https://gerrit.wikimedia.org/r/863352

Change 863353 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/PageTriage@master] articleInfo.js: general cleanup and simplifications

https://gerrit.wikimedia.org/r/863353

Change 863352 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] models/ext.pageTriage.article.js: general cleanup and simplifications

https://gerrit.wikimedia.org/r/863352

Change 863353 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] articleInfo.js: general cleanup and simplifications

https://gerrit.wikimedia.org/r/863353

Change 865132 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/PageTriage@master] Rename wikiLove.js to WikiLove.js and simplify ToolbarView.js

https://gerrit.wikimedia.org/r/865132

Change 865132 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Rename wikilove.js to wikiLove.js and simplify ToolbarView.js

https://gerrit.wikimedia.org/r/865132

What's left here @DannyS712 ? Anything I can help review?

Nothing at the moment, but I'm not as active at the moment - lets just close this