Page MenuHomePhabricator
Create Task
Maniphest T309069

Replace and then retire the perform-test pipeline
Closed, ResolvedPublic
Actions

Description

Replace and then retire the “perform test” pipeline (which uses a special-purpose backend endpoint). In the new approach, have php code request runs for each tester, employing WikiFunctions normal backend APIs, and taking advantage of caching and metadata-based result envelopes to return metrics.

Note: this was discussed in the May 5, 2022 Abstract Wikipedia engineering meeting.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make ApiPerformTest return test metadata, not validate metadatamediawiki/extensions/WikiLambdamaster+74 -92
Fix ZFunctionTesterReport to handle Benjamin arraysmediawiki/extensions/WikiLambdamaster+10 -4
Make getValueFromCanonicalZMap handle global keysmediawiki/extensions/WikiLambdamaster+4 -2
Make ApiPerformTest return test metadata, not validate metadatamediawiki/extensions/WikiLambdamaster+9 -2
Decode orchestrator response before passing to ZObjectFactory::create()mediawiki/extensions/WikiLambdamaster+8 -4
Drop performTest pipelinemediawiki/services/function-orchestratormaster+0 -406
Migrate tester pipeline into MWmediawiki/extensions/WikiLambdamaster+195 -44
Customize query in gerrit

Related Objects

Event Timeline

DMartin-WMF created this task.May 24 2022, 1:35 AM
Jdforrester-WMF added a project: function-orchestrator.May 24 2022, 6:39 PM
Jdforrester-WMF added a project: WikiLambda.
Jdforrester-WMF moved this task from To Triage to Phase κ – Clean-up on the Abstract Wikipedia team board.
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.
Jdforrester-WMF claimed this task.Jun 9 2022, 2:09 PM
gerritbot added a comment.Jun 14 2022, 5:28 PM

Change 805451 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] [WIP] Migrate tester pipeline into MW

https://gerrit.wikimedia.org/r/805451

gerritbot added a project: Patch-For-Review.Jun 14 2022, 5:28 PM
gerritbot added a comment.Jun 15 2022, 7:24 PM

Change 805896 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] [WIP] Drop performTest pipeline

https://gerrit.wikimedia.org/r/805896

gerritbot added a comment.Jun 24 2022, 8:28 PM

Change 805451 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Migrate tester pipeline into MW

https://gerrit.wikimedia.org/r/805451

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jun 24 2022, 9:00 PM
gerritbot added a comment.Jul 6 2022, 8:18 PM

Change 805896 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Drop performTest pipeline

https://gerrit.wikimedia.org/r/805896

Jdforrester-WMF mentioned this in rMSFO6fba308a50ba: Drop performTest pipeline.Jul 6 2022, 8:18 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 6 2022, 8:30 PM
gerritbot added a comment.Jul 27 2022, 6:22 AM

Change 817629 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Decode orchestrator response before passing to ZObjectFactory::create()

https://gerrit.wikimedia.org/r/817629

gerritbot added a project: Patch-For-Review.Jul 27 2022, 6:22 AM
gerritbot added a comment.Jul 27 2022, 4:57 PM

Change 817629 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Decode orchestrator response before passing to ZObjectFactory::create()

https://gerrit.wikimedia.org/r/817629

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.23; 2022-08-01); removed MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jul 27 2022, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 27 2022, 5:31 PM
gerritbot added a comment.Jul 30 2022, 5:30 AM

Change 818528 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Make ApiPerformTest return test metadata, not validate metadata

https://gerrit.wikimedia.org/r/818528

gerritbot added a project: Patch-For-Review.Jul 30 2022, 5:30 AM
gerritbot added a comment.Jul 31 2022, 1:59 AM

Change 818595 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Make getValueFromCanonicalZMap handle global keys

https://gerrit.wikimedia.org/r/818595

gerritbot added a comment.Jul 31 2022, 5:22 AM

Change 818597 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Fix computed properties to handle Benjamin arrays

https://gerrit.wikimedia.org/r/818597

gerritbot added a comment.Aug 1 2022, 1:15 AM

Change 818632 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Adapt FE code to new tester pipeline

https://gerrit.wikimedia.org/r/818632

gerritbot added a comment.Aug 2 2022, 8:32 PM

Change 818528 abandoned by David Martin:

[mediawiki/extensions/WikiLambda@master] Make ApiPerformTest return test metadata, not validate metadata

Reason:

Moving these changes into https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/818632

https://gerrit.wikimedia.org/r/818528

gerritbot added a comment.Aug 3 2022, 11:18 AM

Change 818595 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Make getValueFromCanonicalZMap handle global keys

https://gerrit.wikimedia.org/r/818595

gerritbot added a comment.Aug 3 2022, 11:21 AM

Change 818597 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix ZFunctionTesterReport to handle Benjamin arrays

https://gerrit.wikimedia.org/r/818597

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.25; 2022-08-15); removed MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Aug 3 2022, 12:00 PM
Jdforrester-WMF closed this task as Resolved.Aug 3 2022, 12:24 PM
gerritbot added a comment.Aug 3 2022, 6:11 PM

Change 818632 merged by David Martin:

[mediawiki/extensions/WikiLambda@master] Make ApiPerformTest return test metadata, not validate metadata

https://gerrit.wikimedia.org/r/818632

Maintenance_bot removed a project: Patch-For-Review.Aug 3 2022, 6:30 PM
DMartin-WMF mentioned this in T320509: Rework/rewrite the wikilambda_perform_test API.Oct 11 2022, 5:28 PM
Jdforrester-WMF mentioned this in T311163: Replace hardcoded performTest response with makeResultEnvelope and a specific error type.Nov 28 2022, 7:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits