Page MenuHomePhabricator
Create Task
Maniphest T309073

Mentorship: add gender support to messages
Closed, ResolvedPublic
Actions

Description

The messages growthexperiments-homepage-mentorship-about-mentor-par1 and -par2 discuss a mentor in third person. If I understand correctly, these messages refer to a specific, known user, and it's not just a generic person. In some languages, it would be much better to describe that user using their gender, with correct pronouns and verb forms. Many other GrowthExperiments have gender support for both the mentor and the mentee, so these messages should support it, too.

The following message keys need to support mentor gender as well:

For mentees: (patch)
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-homepage-mentorship-preintro/en
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-homepage-mentorship-about-subheader-mentor/en
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-homepage-mentorship-optout-text/en
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-tour-mentor-response-tip-personal-title/en
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-help-panel-button-header-ask-help-mentor/en

For mentors (patch):
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-mentor-dashboard-mentor-tools-away-dialog-text/en
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-mentor-dashboard-mentor-tools-info-text/en
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-mentor-dashboard-resources-link-how-to-introduce/en
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-mentor-dashboard-mentee-overview-info-legend-questions/en
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-claimmentee-confirm/en

Details

SubjectRepoBranchLines +/-
Mentorship: add gender support to mentor-facing messagesmediawiki/extensions/GrowthExperimentsmaster+5 -5
Mentorship: add gender support to mentee-facing messagesmediawiki/extensions/GrowthExperimentsmaster+205 -145
Mentorship: add gender support to growthexperiments-homepage-mentorship-about-mentor-par1 and -par2mediawiki/extensions/GrowthExperimentsmaster+11 -6
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.May 24 2022, 6:53 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 24 2022, 6:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• mewoph claimed this task.May 26 2022, 10:26 PM
• mewoph edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
• mewoph moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.May 26 2022, 11:15 PM

Change 800309 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Mentorship: add gender support to growthexperiments-homepage-mentorship-about-mentor-par1 and -par2

https://gerrit.wikimedia.org/r/800309

gerritbot added a project: Patch-For-Review.May 26 2022, 11:15 PM
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 26 2022, 11:16 PM
kostajh merged a task: T309510: Support user's mentor gender for messages in Mentorship module.May 30 2022, 1:06 PM
kostajh added a subscriber: Iniquity.
kostajh subscribed.

Note that T309510 has a longer list of messages that may need to be considered for this task.

Iniquity awarded a token.May 30 2022, 1:07 PM
kostajh added a comment.Jun 1 2022, 4:52 PM
In T309073#7962122, @gerritbot wrote:

Change 800309 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Mentorship: add gender support to growthexperiments-homepage-mentorship-about-mentor-par1 and -par2

https://gerrit.wikimedia.org/r/800309

+2'ed, but we still need to consider the items on the list from T309510: Support user's mentor gender for messages in Mentorship module:

https://translatewiki.net/wiki/MediaWiki:Growthexperiments-mentor-writer-error-already-added
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-mentor-list-unexpected-key-mentor
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-mentor-dashboard-mentor-tools-away-dialog-text
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-mentor-dashboard-mentor-tools-info-text
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-mentor-dashboard-resources-link-how-to-introduce
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-mentor-dashboard-mentee-overview-info-legend-questions
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-homepage-mentorship-about-subheader-mentor
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-homepage-mentorship-optout-text
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-claimmentee-confirm
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-tour-mentor-response-tip-personal-title
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-help-panel-button-header-ask-help-mentor

gerritbot added a comment.Jun 1 2022, 5:13 PM

Change 800309 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentorship: add gender support to growthexperiments-homepage-mentorship-about-mentor-par1 and -par2

https://gerrit.wikimedia.org/r/800309

Maintenance_bot removed a project: Patch-For-Review.Jun 1 2022, 5:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 1 2022, 6:00 PM
• mewoph renamed this task from add gender support to growthexperiments-homepage-mentorship-about-mentor-par1 and -par2 to Mentorship: add gender support to messages.Jun 1 2022, 9:43 PM
• mewoph updated the task description. (Show Details)
• mewoph moved this task from Code Review to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Moving back to in progress to add gender support to the rest of the messages

Amire80 updated the task description. (Show Details)Jun 23 2022, 8:32 AM
Amire80 updated the task description. (Show Details)
• mewoph updated the task description. (Show Details)Jun 23 2022, 6:12 PM
gerritbot added a comment.Jun 23 2022, 8:05 PM

Change 808065 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Mentorship: add gender support to mentee-facing messages

https://gerrit.wikimedia.org/r/808065

gerritbot added a project: Patch-For-Review.Jun 23 2022, 8:05 PM
• mewoph updated the task description. (Show Details)Jun 23 2022, 8:06 PM
gerritbot added a comment.Jun 23 2022, 9:51 PM

Change 808084 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Mentorship: add gender support to mentor-facing messages

https://gerrit.wikimedia.org/r/808084

• mewoph updated the task description. (Show Details)Jun 23 2022, 9:52 PM
• mewoph updated the task description. (Show Details)
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Jun 24 2022, 8:33 AM

Change 808084 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentorship: add gender support to mentor-facing messages

https://gerrit.wikimedia.org/r/808084

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.18; 2022-06-27); removed MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 24 2022, 9:00 AM
gerritbot added a comment.Jun 24 2022, 6:32 PM

Change 808065 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentorship: add gender support to mentee-facing messages

https://gerrit.wikimedia.org/r/808065

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2022, 7:30 PM
• mewoph moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 27 2022, 4:42 PM
• mewoph removed • mewoph as the assignee of this task.Jul 1 2022, 4:41 PM
• mewoph subscribed.
Etonkovidova closed this task as Resolved.Jul 14 2022, 9:51 PM
Etonkovidova claimed this task.
Etonkovidova subscribed.

Checked messages on translatewiki.net (e.g. https://translatewiki.net/wiki/Special:Translations?message=MediaWiki%3AGrowthexperiments-claimmentee-confirm&namespace=8) and on ruwiki wmf.19.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL