[JS] dispatch method should warn when stream configs are disabled
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	phuedx
	May 24 2022, 8:52 AM

Description

Background

When stream configs are disabled, i.e. $wgEventLoggingStreamNames = false;, MetricsClient::dispatch() returns early without attempting to notify the instrumentor.

AC

Calling MetricsClient::dispatch() should log a warning to the logging backend of the execution environment (via Integration::logWarning())

Details

	Subject	Repo	Branch	Lines +/-
	[JS] Warn when stream configs are disabled	mediawiki/libs/metrics-platform	master	+19 -0

Customize query in gerrit

Event Timeline

phuedx created this task.May 24 2022, 8:52 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2022, 8:52 AM

Change 798520 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/libs/metrics-platform@master] [JS] Warn when stream configs are disabled

https://gerrit.wikimedia.org/r/798520

gerritbot added a project: Patch-For-Review.May 24 2022, 9:49 AM

• EChetty moved this task from Discussed to QA/Review on the Metrics Platform Backlog board.May 24 2022, 12:35 PM

Change 798520 merged by jenkins-bot:

[mediawiki/libs/metrics-platform@master] [JS] Warn when stream configs are disabled

https://gerrit.wikimedia.org/r/798520

Maintenance_bot removed a project: Patch-For-Review.May 25 2022, 4:30 PM

phuedx updated the task description. (Show Details)May 30 2022, 3:40 PM

phuedx moved this task from QA/Review to Done on the Metrics Platform Backlog board.

• EChetty closed this task as Resolved.Oct 1 2022, 4:15 PM

[JS] dispatch method should warn when stream configs are disabledClosed, ResolvedPublicActions

Description

Background

AC

Details

Event Timeline

[JS] dispatch method should warn when stream configs are disabled
Closed, ResolvedPublic
Actions