TypeError: Argument 3 passed to GrowthExperiments\NewcomerTasks\TemplateBasedTaskSubmissionHandler::validate() must be of the type integer, null given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	dancy
	May 24 2022, 4:41 PM

Description

Error

mwversion: 1.39.0-wmf.12
reqId: 63b0e150-9cea-4b75-8bba-b5fc1e1f0849
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   TypeError: Argument 3 passed to GrowthExperiments\NewcomerTasks\TemplateBasedTaskSubmissionHandler::validate() must be of the type integer, null given, called in /srv/mediawiki/php-1.39.0-wmf.12/extensions/GrowthExperiments/inc

exception.trace

from /srv/mediawiki/php-1.39.0-wmf.12/extensions/GrowthExperiments/includes/NewcomerTasks/TemplateBasedTaskSubmissionHandler.php(19)
#0 /srv/mediawiki/php-1.39.0-wmf.12/extensions/GrowthExperiments/includes/VisualEditorHooks.php(88): GrowthExperiments\NewcomerTasks\TemplateBasedTaskSubmissionHandler->validate(MediaWiki\Page\PageIdentityValue, User, NULL, array)
#1 /srv/mediawiki/php-1.39.0-wmf.12/includes/HookContainer/HookContainer.php(160): GrowthExperiments\VisualEditorHooks->onVisualEditorApiVisualEditorEditPreSave(MediaWiki\Page\PageIdentityValue, User, string, array, array, array)
#2 /srv/mediawiki/php-1.39.0-wmf.12/extensions/VisualEditor/includes/VisualEditorHookRunner.php(54): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#3 /srv/mediawiki/php-1.39.0-wmf.12/extensions/VisualEditor/includes/ApiVisualEditorEdit.php(444): MediaWiki\Extension\VisualEditor\VisualEditorHookRunner->onVisualEditorApiVisualEditorEditPreSave(MediaWiki\Page\PageIdentityValue, User, string, array, array, array)
#4 /srv/mediawiki/php-1.39.0-wmf.12/includes/api/ApiMain.php(1902): MediaWiki\Extension\VisualEditor\ApiVisualEditorEdit->execute()
#5 /srv/mediawiki/php-1.39.0-wmf.12/includes/api/ApiMain.php(874): ApiMain->executeAction()
#6 /srv/mediawiki/php-1.39.0-wmf.12/includes/api/ApiMain.php(845): ApiMain->executeActionWithErrorHandling()
#7 /srv/mediawiki/php-1.39.0-wmf.12/api.php(90): ApiMain->execute()
#8 /srv/mediawiki/php-1.39.0-wmf.12/api.php(45): wfApiMain()
#9 /srv/mediawiki/w/api.php(3): require(string)
#10 {main}

Notes

I saw a burst of 6 of these in a row.

Details

Request URL: https://en.wikipedia.org/w/api.php

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	SubmissionHandler: Allow null for baseRev ID	mediawiki/extensions/GrowthExperiments	master	+18 -14

Customize query in gerrit

Related Objects

Duplicates Merged Here: T305420: TypeError: Argument 3 passed to GrowthExperiments\NewcomerTasks\TemplateBasedTaskSubmissionHandler must be of the type integer

Event Timeline

dancy created this task.May 24 2022, 4:41 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 24 2022, 4:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• mewoph merged a task: T305420: TypeError: Argument 3 passed to GrowthExperiments\NewcomerTasks\TemplateBasedTaskSubmissionHandler must be of the type integer.May 26 2022, 10:19 PM

• mewoph edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

• mewoph added subscribers: Etonkovidova, • mewoph, • Tgr and 2 others.

dancy unsubscribed.May 27 2022, 3:41 PM

kostajh claimed this task.May 30 2022, 1:23 PM

kostajh triaged this task as Medium priority.

kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 801391 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] VisualEditorHooks: Ensure int is passed to validate/handle methods

https://gerrit.wikimedia.org/r/801391

gerritbot added a project: Patch-For-Review.May 30 2022, 1:26 PM

kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 30 2022, 1:26 PM

kostajh renamed this task from TypeError: Argument 3 passed to GrowthExperiments\NewcomerTasks\TemplateBasedTaskSubmissionHandler::validate() must be of the type integer, null given, called in /srv/mediawiki/php-1.39.0-wmf.12/extensions/GrowthExperiments/inc to TypeError: Argument 3 passed to GrowthExperiments\NewcomerTasks\TemplateBasedTaskSubmissionHandler::validate() must be of the type integer, null given.May 30 2022, 7:13 PM

Change 801391 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SubmissionHandler: Allow null for baseRev ID

https://gerrit.wikimedia.org/r/801391

Maintenance_bot removed a project: Patch-For-Review.May 31 2022, 6:30 PM

• mewoph moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 31 2022, 6:48 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).May 31 2022, 7:00 PM

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 3 2022, 12:59 AM

Krinkle moved this task from Untriaged to May 2022 on the Wikimedia-production-error board.Jun 7 2022, 10:00 PM

Etonkovidova closed this task as Resolved.Jun 27 2022, 11:52 PM