The issue is described at the bottom of https://fr.wikipedia.org/wiki/Utilisateur:Dom/Brouillon/VisualEditor_template_dialog_improvements.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix template dialog sometimes deleting unrelated params | mediawiki/extensions/VisualEditor | master | +5 -6 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | thiemowmde | T310248 Make duplicate/conflicting template parameters editable in VisualEditor | |||
| Resolved | BUG REPORT | thiemowmde | T309203 Unrelated parameters disappear when confronted with duplicate aliases |
Event Timeline
Comment Actions
Change 799347 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/VisualEditor@master] Fix template dialog sometimes deleting unrelated params
Comment Actions
Change 799347 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix template dialog sometimes deleting unrelated params
Comment Actions
How is this possible? It seems to be fixed on the given example page https://fr.wikipedia.org/wiki/Utilisateur:Dom/Brouillon/VisualEditor_template_dialog_improvements. What am I missing? Do you have an example link?
Comment Actions
It seems to be fixed
Can you share screenshots demonstrating what you mean? At least for me, I still see that the ville parameter is missing, because the adresse parameter is an alias for the same parameter and takes precedence in the dialog:
Comment Actions
I think there might have been some confusion about the bug report saying that the parameter "disappears", because the attached patch fixes an issue with the parameters being *deleted*, but the bug seems to only be about the parameters not appearing in the dialog.
Comment Actions
I'm sorry for the confusion. This ticket says:
Unrelated parameters disappear […]
subdivision2 is the unrelated parameter that disappears in the very last example at https://fr.wikipedia.org/wiki/Utilisateur:Dom/Brouillon/VisualEditor_template_dialog_improvements. This is fixed.
Making duplicates like ville and adresse (both are aliases for siège) visible at the same time is not just a bugfix but a design change. Let's please track this separately: T310248.
Comment Actions
Yeah I guess it really is confusing. The ticket says something different than the source. - We should have made the ticket more explicit. So a problem was solved but another remains. I agree that it makes most sense to continue with a new ticket.