Page MenuHomePhabricator

Unable to preview video in Phabricator task comments and descriptions
Open, MediumPublic

Assigned To
None
Authored By
Krinkle
May 25 2022, 3:57 PM
Referenced Files
F41514926: Kapture 2023-11-18 at 16.15.49.webm
Nov 18 2023, 4:34 PM
F41514925: Kapture 2023-11-18 at 16.15.49.mp4
Nov 18 2023, 4:34 PM
F35176668: Screenshot
May 25 2022, 3:57 PM
F35176667: Untitled.mp4
May 25 2022, 3:57 PM
F35176670: Screenshot
May 25 2022, 3:57 PM

Description

Issue

It looks like something may have regressed in configuration as we're currently in a rather strange situation.

  • Allowed upload formats include: video/mp4.
  • Allow playback formats include: video/webm.

This leads to the situation where uploading a mp4 file is allowed, but can't be displayed:

{F35176667}
{F35176667 media=video}


Rendered as:
Screenshot (148×656 px, 14 KB)

And webm is allowed to be displayed in theory, but can't be uploaded:

Result in upload failure:
Screenshot (286×560 px, 44 KB)
Other

I note that this works fine in the upstream Phacility install, e.g. at https://secure.phabricator.com/T6916#179235

I note that in our instance configuration (admin-only: https://phabricator.wikimedia.org/config/edit/files.viewable-mime-types/) we have the following, which controls whether something is displayed:

files.viewable-mime-types Default
{
  ..
  "video/mp4": "video/mp4",
  "video/ogg": "video/ogg",
  "video/webm": "video/webm",
  "video/quicktime": "video/quicktime",
}
files.viewable-mime-types Local config
-  "video/mp4": "video/mp4",
   "video/ogg": "video/ogg",
   "video/webm": "video/webm",
-  "video/quicktime": "video/quicktime",

And for upload handling, https://phabricator.wikimedia.org/config/edit/files.video-mime-types/:

`files.video-mime-types Default unchanged
video/mp4
video/ogg
video/webm
video/quicktime

Which suggests that webm could be uploaded, but I'm guessing it's detected as something else for some reason, aside from ofc webm being much harder to generate for most people, but that's a separate question :)

Event Timeline

Aklapper triaged this task as Medium priority.Jul 13 2023, 5:34 PM
Aklapper moved this task from To Triage to Misc on the Phabricator board.

MP4 (as of writing, uploads fine, but no preview):

WebM (as of writing, also uploads fine, and preview):

So the bug with WebM uploads being disabled is fixed, but perhaps mp4 previews could be enabled as well since those are more likely to be produced by recording software (in my experience).