Page MenuHomePhabricator

Deprecate toolbar nesting
Closed, ResolvedPublic

Description

Originally the toolbar consisted of left-aligned tools, and a right-aligned "actions" area for things like a save button.

And some point we decided it would be better if everything in the toolbar was a tool, to remove custom styling for buttons-in-a-toolbar. To implement this we simply appended another toolbar to the actions area.

Setting up two toolbars leads to problems with things like narrow-mode calculations, as we as being just a messy API.

Instead we should allow toolgroups to specify an alignment: 'before' being on the left (in LTR) by default, and 'after' for tools that were previously in the actions area.

Related Objects

StatusSubtypeAssignedTask
OpenNone
ResolvedNone

Event Timeline

Esanders renamed this task from Deprecated toolbar nesting to Deprecate toolbar nesting.May 25 2022, 4:16 PM

Change 793832 had a related patch set uploaded (by Esanders; author: Esanders):

[oojs/ui@master] Make 'action' tools part of a single toolbar

https://gerrit.wikimedia.org/r/793832

We can't easily deprecate people appending to the $actions element, but we can search for references to it in:

Change 793832 merged by jenkins-bot:

[oojs/ui@master] Make 'action' tools part of a single toolbar

https://gerrit.wikimedia.org/r/793832

matmarex subscribed.

I suggest that we don't bother doing anything more complicated here. The patch above documents it as deprecated.

Change 813630 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Update OOUI to v0.44.1

https://gerrit.wikimedia.org/r/813630

Change 813630 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.44.1

https://gerrit.wikimedia.org/r/813630