Create popup with policy acknowledgement for when users register on the event page
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Daimona
	May 26 2022, 4:42 PM

Description

As a campaign participant, I want to acknowledge the privacy policy and terms of use before registering for an event so I understand the legal guidelines that the event is under.

Prototype links:

Acceptance Criteria:

When the participant registers for the event, they must be able to acknowledge their approval of the terms of use and the privacy policy
The text should say: "By registering, you agree to the Terms of Use and Privacy Policy."
We do not need to include the greeting ("Hello Username!") for V0 and perhaps will not include it in later releases as well, depending on user feedback.

Visual example:

Screen Shot 2022-05-26 at 12.40.26 PM.png (1×2 px, 437 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Display policy acknowledgement popup when registering for an event	mediawiki/extensions/CampaignEvents	master	+127 -11

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Daimona	T308083 [EPIC] Add policy acknowledgment to user flow when registering
		Resolved		Daimona	T309333 Create popup with policy acknowledgement for when users register on the event page

Event Timeline

Daimona created this task.May 26 2022, 4:42 PM

Daimona updated the task description. (Show Details)May 26 2022, 4:44 PM

ldelench_wmf set the point value for this task to 2.May 26 2022, 4:57 PM

ldelench_wmf moved this task from Backlog to Estimated/Ready for work on the Campaign-Tools board.

• mdedul.islam.16 closed this task as a duplicate of T309357: *spam*.May 26 2022, 9:33 PM

TheresNoTime reopened this task as Open.May 26 2022, 9:42 PM

Added to sprint 15 per discussion at 2022-06-09 sprint planning.

ldelench_wmf mentioned this in T308083: [EPIC] Add policy acknowledgment to user flow when registering.Jun 13 2022, 7:59 PM

Daimona claimed this task.Jun 15 2022, 12:10 AM

Daimona updated the task description. (Show Details)Jun 15 2022, 12:25 PM

Change 805847 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Display policy acknowledgement popup when registering for an event

https://gerrit.wikimedia.org/r/805847

gerritbot added a project: Patch-For-Review.Jun 15 2022, 3:48 PM

Testing notes: T309334#8005531

Change 805847 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Display policy acknowledgement popup when registering for an event

https://gerrit.wikimedia.org/r/805847

Daimona mentioned this in rUCAM3fb4a3f6c548: Display policy acknowledgement popup when registering for an event.Jun 21 2022, 5:05 AM

Maintenance_bot removed a project: Patch-For-Review.Jun 21 2022, 5:30 AM

QA notes: T309334#8005531

A few comments on this ticket (which apply to T309334 as well) :

font-weight in the comp for the text By registering, you agree to the Terms of Use and Privacy Policy. is slightly lighter than it is in the build. If we change that to font-weight:300 then it matches the comp.

comp:

build:

I am assuming we do not need a licensing policy link now since it is not in the AC, but since it is in the comp I wanted to mention it here.

Also @Daimona When I follow the QA testing notes T309334#8005531, and then click the terms of use and privacy policy links in the UI, the links open in the same window, but they should open in a new tab. When we have the Campaign Events extension and the terms of use and privacy policy on beta cluster, will we be able to have them open in a new tab? If so, is possible to test or recreate that on local currently?

vaughnwalters attached a referenced file: F35265835: comp.png. (Show Details)Jun 23 2022, 4:00 AM

vaughnwalters attached a referenced file: F35265842: build.png. (Show Details)

In T309333#8021426, @vaughnwalters wrote:

A few comments on this ticket (which apply to T309334 as well) :

font-weight in the comp for the text By registering, you agree to the Terms of Use and Privacy Policy. is slightly lighter than it is in the build. If we change that to font-weight:300 then it matches the comp.

I think this could be a small difference due to using figma vs the actual OOUI component. In the code, we're using the standard message dialog component without changes.

Also @Daimona When I follow the QA testing notes T309334#8005531, and then click the terms of use and privacy policy links in the UI, the links open in the same window, but they should open in a new tab. When we have the Campaign Events extension and the terms of use and privacy policy on beta cluster, will we be able to have them open in a new tab? If so, is possible to test or recreate that on local currently?

I intentionally made it open in the same tab because it wasn't mentioned in the AC. I personally prefer links that open in the same tab, because you can get the other behaviour by middle-clicking / right-clicking / long-pressing, whereas if the link already opens in a new tab, it's not possible to force the other behaviour. That said, if this is something we should change, it would be a one-liner.

Also @Daimona When I follow the QA testing notes T309334#8005531, and then click the terms of use and privacy policy links in the UI, the links open in the same window, but they should open in a new tab. When we have the Campaign Events extension and the terms of use and privacy policy on beta cluster, will we be able to have them open in a new tab? If so, is possible to test or recreate that on local currently?

I intentionally made it open in the same tab because it wasn't mentioned in the AC. I personally prefer links that open in the same tab, because you can get the other behaviour by middle-clicking / right-clicking / long-pressing, whereas if the link already opens in a new tab, it's not possible to force the other behaviour. That said, if this is something we should change, it would be a one-liner.

Okay I see - I was going off of the figma interaction (which may be a default interaction for external links in figma?) and personal preference, but would be interested to see what @gonyeahialam thinks.

vaughnwalters moved this task from QA 🐛 to Product sign-off 🤘 on the Campaign-Tools (Campaign-Tools-Sprint-15) board.Jun 27 2022, 3:26 PM

In T309333#8022929, @vaughnwalters wrote:

Also @Daimona When I follow the QA testing notes T309334#8005531, and then click the terms of use and privacy policy links in the UI, the links open in the same window, but they should open in a new tab. When we have the Campaign Events extension and the terms of use and privacy policy on beta cluster, will we be able to have them open in a new tab? If so, is possible to test or recreate that on local currently?

I intentionally made it open in the same tab because it wasn't mentioned in the AC. I personally prefer links that open in the same tab, because you can get the other behaviour by middle-clicking / right-clicking / long-pressing, whereas if the link already opens in a new tab, it's not possible to force the other behaviour. That said, if this is something we should change, it would be a one-liner.

Okay I see - I was going off of the figma interaction (which may be a default interaction for external links in figma?) and personal preference, but would be interested to see what @gonyeahialam thinks.

@vaughnwalters, @Daimona's suggestion seems to be the best solution in this context. Links open in the same tab, users can right-click if they want it in a new tab.

ldelench_wmf edited projects, added Campaign-Tools (Campaign-Tools-Sprint-16); removed Campaign-Tools (Campaign-Tools-Sprint-15).Jul 6 2022, 4:50 PM

ldelench_wmf moved this task from Ready 🎬 to Product sign-off 🤘 on the Campaign-Tools (Campaign-Tools-Sprint-16) board.Jul 6 2022, 4:56 PM

ldelench_wmf moved this task from Backlog to V0 on the Campaign-Registration board.Jul 11 2022, 4:09 PM

ldelench_wmf edited projects, added Campaign-Tools (Campaign-Tools-Sprint-17); removed Campaign-Tools (Campaign-Tools-Sprint-16).Jul 20 2022, 1:28 AM

ldelench_wmf moved this task from Ready 🎬 to Product sign-off 🤘 on the Campaign-Tools (Campaign-Tools-Sprint-17) board.Jul 20 2022, 1:31 AM

ldelench_wmf edited projects, added Campaign-Tools (Campaign-Tools-Current-Sprint); removed Campaign-Tools (Campaign-Tools-Sprint-17).Aug 14 2022, 9:29 PM

ldelench_wmf moved this task from Needs Input / Design in progress to Product sign-off 🤘 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Aug 14 2022, 9:34 PM

• vyuen moved this task from V0 to Darkship on the Campaign-Registration board.Aug 24 2022, 2:18 PM

• vyuen changed the task status from Open to In Progress.Aug 25 2022, 12:51 PM

ifried mentioned this in T316408: Improve policy notification when registering.Aug 26 2022, 8:32 PM

T309332#8250907 should cover this @ifried

• vyuen moved this task from Darkship to V1 (MVP) on the Campaign-Registration board.Sep 22 2022, 2:06 PM

ifried mentioned this in T318368: Update policy notification when registering.Sep 23 2022, 12:52 PM

The policy message is now displaying (see screenshot example), so I'm marking this as Done.

There are further enhancements we will make to the message, but these changes will be tackled in separate tickets.

Screen Shot 2022-09-23 at 5.01.40 PM.png (804×1 px, 135 KB)

ifried closed this task as Resolved.Sep 23 2022, 9:02 PM

ifried moved this task from Product sign-off 🤘 to Done 🏁 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.

sbassett mentioned this in T290248: Security Readiness Review For Campaigns Registration System.Sep 30 2022, 7:58 PM

	F35531243: Screen Shot 2022-09-23 at 5.01.40 PM.png
	Sep 23 2022, 9:01 PM

	F35179647: Screen Shot 2022-05-26 at 12.40.26 PM.png
	May 26 2022, 4:44 PM

	F35265842: build.png
	Jun 22 2022, 10:07 PM

	F35265835: comp.png
	Jun 22 2022, 10:07 PM

Create popup with policy acknowledgement for when users register on the event pageClosed, ResolvedPublic2 Estimated Story PointsActions

Description

Details

Related ObjectsSearch...

Event Timeline

Create popup with policy acknowledgement for when users register on the event page
Closed, ResolvedPublic2 Estimated Story Points
Actions

Related Objects
Search...