Page MenuHomePhabricator

Hide the "IP Information" infobox header from mobile
Closed, ResolvedPublic3 Estimated Story Points

Description

Motivation

We decided to disable IPInfo from mobile (T304432: Temporarily disable IPInfo from mobile) until we were clear that it was useful to have it there. However according to a recent bug report filed by @Yahya - T309355: IP Information dropdown doesn't work on mobile it seems like we are still showing the infobox header even though clicking on it doesn't do anything. We should get rid of the header completely.

Spec
  • "IP Information" header is no longer visible on mobile

Event Timeline

Niharika triaged this task as Medium priority.May 26 2022, 11:42 PM
Niharika created this task.
WhitePhosphorus subscribed.

Only JS and CSS rules are disabled on mobile explicitly by rEIPI5431b44d6b86: Explicitly disable IPInfo for mobile targets, but the infobox is always inserted to page html in src/HookHandler/InfoboxHandler.php. Possible fix: add oo-ui-element-hidden class to new PanelLayout() in php file to make the infobox hidden by default, then remove the class in modules/ext.ipInfo/infobox/init.js.

Change 801838 had a related patch set uploaded (by WhitePhosphorus; author: WhitePhosphorus):

[mediawiki/extensions/IPInfo@master] Hide IP Information panel from mobile

https://gerrit.wikimedia.org/r/801838

WhitePhosphorus changed the task status from Open to Stalled.Jun 1 2022, 5:18 AM

The patch cannot be merged until unit tests are fixed in T309678.

Tchanders changed the task status from Stalled to Open.Jun 1 2022, 2:35 PM

Change 801838 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Hide IP Information panel from mobile

https://gerrit.wikimedia.org/r/801838

dom_walden subscribed.

The infobox does not appear on mobile view (e.g. https://en.m.wikipedia.beta.wmflabs.org).

It does appear on Minerva and all the other skins.

Test environment: https://en.wikipedia.beta.wmflabs.org IP Info 0.0.0 (2dca33e) 19:10, 6 June 2022.
Test browsers: Firefox 91, iPhone 8 iOS 15.4 Safari (emulator).

It does appear on Minerva and all the other skins.

This is a good point - I think it's acceptable since Minerva on Desktop isn't supported.