Page MenuHomePhabricator
Create Task
Maniphest T309370

[betalabs] Non-responsive sticky header appears on Special and Talk pages
Closed, ResolvedPublic
Actions

Assigned To
ovasileva
Authored By
Etonkovidova
May 27 2022, 2:02 AM
Tags
Referenced Files
F35233266: Screen Recording 2022-06-12 at 5.11.34 PM.mov.gif
Jun 13 2022, 12:13 AM
F35233265: Screen Recording 2022-06-12 at 5.12.37 PM.mov.gif
Jun 13 2022, 12:13 AM
F35233268: Screen Recording 2022-06-12 at 5.11.11 PM.mov.gif
Jun 13 2022, 12:13 AM
F35219376: Screen Shot 2022-06-08 at 9.34.05 AM.png
Jun 8 2022, 4:35 PM
F35210441: Screen Recording 2022-06-05 at 7.40.27 PM.mov.gif
Jun 8 2022, 4:35 PM
F35180788: Screen Shot 2022-05-26 at 6.58.19 PM.png
May 27 2022, 2:02 AM
F35180783: Screen Shot 2022-05-26 at 6.43.47 PM.png
May 27 2022, 2:02 AM
F35180776: Screen Shot 2022-05-26 at 6.54.10 PM.png
May 27 2022, 2:02 AM
View All 9 Files
Subscribers
Aklapper
Edtadros
Etonkovidova
Jdlrobson
Jdrewniak
• nray

Description

The issue seems to be happening only in betalabs`.

  1. On enwiki betalabs go Special:RecentChanges and scroll down.
  2. The sticky header appears. Scroll up - the sticky header is still [present blocking mw-header menu options.

The same issue happens on Talk apges.

Clicking on the sticky header controls have no effect (the Console doesn't show any errors). Reloading the page shows the menu options only momentarily to be replaced by the sticky header.

Screen Shot 2022-05-26 at 6.54.10 PM.png (345×1 px, 91 KB)
Screen Shot 2022-05-26 at 6.45.08 PM.png (381×1 px, 78 KB)
Screen Shot 2022-05-26 at 6.43.47 PM.png (414×1 px, 93 KB)

The menu buttons are slightly visible

Screen Shot 2022-05-26 at 6.58.19 PM.png (76×407 px, 8 KB)

QA Results - Beta

ACStatusDetails
1✅T309370#7989660

QA Results - Prod

ACStatusDetails
1✅T309370#7997349

Details

SubjectRepoBranchLines +/-
Sticky header edit button A/B test bucketing (updated)mediawiki/skins/Vectormaster+91 -26
Revert "Sticky header edit button A/B test bucketing"mediawiki/skins/Vectormaster+20 -67
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.May 27 2022, 2:02 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2022, 2:02 AM
Etonkovidova moved this task from Incoming to Sticky header on the Desktop Improvements (Vector 2022) board.May 27 2022, 2:03 AM
Jdlrobson added projects: Regression, Web-Team-Backlog (Kanbanana-FY-2021-22).May 27 2022, 4:18 PM
Jdlrobson added subscribers: • nray, Jdlrobson.

This was also picked up by @nray using our UI regression suite.
https://pixel.wmcloud.org/desktop/index.html

Jdlrobson triaged this task as Unbreak Now! priority.May 27 2022, 4:18 PM
Jdlrobson added a parent task: T308067: 1.39.0-wmf.14 deployment blockers.
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.May 27 2022, 4:34 PM
gerritbot added a comment.May 27 2022, 4:36 PM

Change 800697 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Revert "Sticky header edit button A/B test bucketing"

https://gerrit.wikimedia.org/r/800697

gerritbot added a project: Patch-For-Review.May 27 2022, 4:36 PM
Jdlrobson mentioned this in T299959: Implement sticky header A/B test bucketing.May 27 2022, 4:38 PM
Etonkovidova added a comment.May 27 2022, 5:02 PM
In T309370#7963561, @Jdlrobson wrote:

This was also picked up by @nray using our UI regression suite.
https://pixel.wmcloud.org/desktop/index.html

Great tool! It'd be very useful to use for GrowthExperiments feature regression testing.

Jdlrobson assigned this task to Edtadros.May 27 2022, 6:09 PM
Jdlrobson moved this task from Upcoming to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.May 27 2022, 6:30 PM

Change 800697 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Revert "Sticky header edit button A/B test bucketing"

https://gerrit.wikimedia.org/r/800697

Jdlrobson lowered the priority of this task from Unbreak Now! to High.May 27 2022, 6:34 PM
Jdlrobson removed a parent task: T308067: 1.39.0-wmf.14 deployment blockers.

After revert, looks fixed at casual glance so removing as a deploy blocker.

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.14; 2022-05-30).May 27 2022, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 27 2022, 7:30 PM
Jdrewniak claimed this task.May 30 2022, 2:44 PM
Jdrewniak added a subscriber: Edtadros.
gerritbot added a comment.May 31 2022, 4:15 AM

Change 801458 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Sticky header edit button A/B test bucketing (updated)

https://gerrit.wikimedia.org/r/801458

gerritbot added a project: Patch-For-Review.May 31 2022, 4:15 AM
Jdrewniak removed Jdrewniak as the assignee of this task.May 31 2022, 4:16 AM
Jdrewniak moved this task from QA to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdrewniak subscribed.
Jdlrobson claimed this task.May 31 2022, 5:05 PM
gerritbot added a comment.Jun 1 2022, 4:20 PM

Change 801458 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Sticky header edit button A/B test bucketing (updated)

https://gerrit.wikimedia.org/r/801458

Maintenance_bot removed a project: Patch-For-Review.Jun 1 2022, 4:30 PM
Jdlrobson reassigned this task from Jdlrobson to Edtadros.Jun 1 2022, 4:35 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.15; 2022-06-06); removed MW-1.39-notes (1.39.0-wmf.14; 2022-05-30).Jun 1 2022, 5:00 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 8 2022, 4:35 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Sticky header should not appear on Special pages. Only in Beta should it appear on the main page.

Screen Shot 2022-06-08 at 9.34.05 AM.png (356×978 px, 227 KB)

Screen Recording 2022-06-05 at 7.40.27 PM.mov.gif (548×1 px, 2 MB)

Edtadros reassigned this task from Edtadros to ovasileva.Jun 13 2022, 12:13 AM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Sticky header should not appear on Special pages. Only in Beta should it appear on the main page.

Screen Recording 2022-06-12 at 5.12.37 PM.mov.gif (542×1 px, 1 MB)

Screen Recording 2022-06-12 at 5.11.34 PM.mov.gif (542×1 px, 2 MB)

Screen Recording 2022-06-12 at 5.11.11 PM.mov.gif (542×1 px, 3 MB)

Edtadros updated the task description. (Show Details)Jun 13 2022, 12:15 AM
ovasileva closed this task as Resolved.Jun 13 2022, 7:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits