Page MenuHomePhabricator

Add article icon-link to sticky header on talk pages
Closed, ResolvedPublic3 Estimated Story Points

Description

Description

When you are on an article page the sticky header has an icon-link that takes you to the talk page. This task is regarding the sticky header on talk pages. We should:

  • remove the talk icon-link
  • add an article icon-link

Design

link to prototype: https://di-collapsible-menus.web.app/Zebra

Event Timeline

Tacsipacsi subscribed.

Since the same icon appears in content namespaces as well (i.e. a talk page icon—which is not a self-link there), I consider this a bug, not a feature with questionable impact. Either it should be removed, or it should be symmetrical to the content-namespace version, and link from the talk page to the content page.

Having a self link in the sticky header is not useful at all, and it would be nice if it could link to the content-namespace version instead (with a different icon to distinguish both) as @Tacsipacsi suggested.

ovasileva triaged this task as Medium priority.Jun 2 2022, 4:42 PM

@ppelberg - discussed with Alex today. We think the next step would be to add a link to the article, for which we already have an icon. @alexhollender_WMF to add a mock. Does that sound good from your side?

alexhollender_WMF renamed this task from Decide what to do about the talk page icon that appears within the sticky header to Add article icon-link to sticky header on talk pages.Jun 8 2022, 5:53 PM
alexhollender_WMF updated the task description. (Show Details)

@ppelberg - discussed with Alex today. We think the next step would be to add a link to the article, for which we already have an icon. @alexhollender_WMF to add a mock. Does that sound good from your side?

@ovasileva + @alexhollender_WMF: adding a link to the article page within the sticky header that appears on talk pages sounds great to me. Nice!

Hey @cjming just realized we need a feature flag for showing the sticky header on the talk page which might be a blocker for doing this task. We should not be turning on the sticky header on talk pages as part of this task. @ovasileva will create those tickets shortly.

Change 784297 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/Vector@master] Enable sticky header on article and user talk pages

https://gerrit.wikimedia.org/r/784297

Change 784297 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Enable sticky header on article and user talk pages

https://gerrit.wikimedia.org/r/784297

Change 816225 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/Vector@master] Sticky header: Add a link to the 'subject' page when on talk pages

https://gerrit.wikimedia.org/r/816225

Change 816225 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Sticky header: Add a link to the 'subject' page when on talk pages

https://gerrit.wikimedia.org/r/816225

matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
matmarex edited projects, added Editing QA; removed Patch-For-Review.
matmarex added a subscriber: cjming.
EAkinloose subscribed.

✅ Add article icon-link to sticky header on talk pages

Screenshot 2022-08-03 at 04.44.19.png (430×3 px, 148 KB)

Experience: https://photos.app.goo.gl/eXmix6DWwX9HWWhCA