panic: no binary release found when running "mw update"
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	TheresNoTime
	May 28 2022, 11:01 PM

Description

Caused by mwcli looking for a released binary called mw_v0.14.0_windows_amd64 and not mw_v0.14.0_windows_amd64.exe

mw update -vv
level=trace msg="mwcli: PersistentPreRun"
? Do you want to update? Yes
Updating binary  11% |███████                                                          | (11/100, 10 it/s)
[1s:8s]panic: no binary release found: mw_v0.14.0_windows_amd64

goroutine 1 [running]:
gitlab.wikimedia.org/repos/releng/cli/internal/updater.UpdateFromGitlab(0x1503e40, 0x6, 0x1504c00, 0x7, 0xc0003c0000, 0x0, 0x0)
        /builds/repos/releng/cli/internal/updater/gitlab.go:57 +0x2d7
gitlab.wikimedia.org/repos/releng/cli/internal/updater.Update(...)
        /builds/repos/releng/cli/internal/updater/root.go:19
gitlab.wikimedia.org/repos/releng/cli/internal/cmd/update.NewUpdateCmd.func1(0xc0006bec80, 0xc0002b9570, 0x0, 0x1)
        /builds/repos/releng/cli/internal/cmd/update/root.go:70 +0x248
github.com/spf13/cobra.(*Command).execute(0xc0006bec80, 0xc0002b9560, 0x1, 0x1, 0xc0006bec80, 0xc0002b9560)
        /go/pkg/mod/github.com/spf13/cobra@v1.3.0/command.go:860 +0x2c2
github.com/spf13/cobra.(*Command).ExecuteC(0xc00044a000, 0x6, 0xc00050f0b6, 0x3)
        /go/pkg/mod/github.com/spf13/cobra@v1.3.0/command.go:974 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
        /go/pkg/mod/github.com/spf13/cobra@v1.3.0/command.go:902
gitlab.wikimedia.org/repos/releng/cli/cmd.Execute(0x1504bf8, 0x7, 0x1503e30, 0x4, 0x1503e38, 0x5, 0x1504c00, 0x7, 0x1507b70, 0x14, ...)
        /builds/repos/releng/cli/cmd/root.go:204 +0x390
main.main()
        /builds/repos/releng/cli/main.go:29 +0xbc

Event Timeline

TheresNoTime claimed this task.May 28 2022, 11:01 PM

TheresNoTime created this task.

There might be a more ~~pythonic~~ go-thonic way of doing this, but..

if os == "windows" {
    return "mw_" + tagName + "_" + os + "_" + arch + ".exe"
} else {
    return "mw_" + tagName + "_" + os + "_" + arch
}

merge request

TheresNoTime updated the task description. (Show Details)May 28 2022, 11:13 PM

Addshore moved this task from Inbox to Pending Release on the mwcli board.May 29 2022, 9:19 PM

Addshore awarded a token.

TheresNoTime removed a project: Patch-For-Review.May 30 2022, 4:48 PM

Stalled on awaiting build & release

Will have been released in v0.15.0

panic: no binary release found when running "mw update"Closed, ResolvedPublicBUG REPORTActions

Description

Event Timeline

panic: no binary release found when running "mw update"
Closed, ResolvedPublicBUG REPORT
Actions