Page MenuHomePhabricator

Improve SimilarEditors test coverage
Open, Needs TriagePublic

Description

Summarized from https://doc.wikimedia.org/cover-extensions/SimilarEditors/, this describes the basic tests needed to pass the programmatic coverage % checks. On a case by case basis, additional tests might be needed to cover different states/errors/etc. I've noted a few here but it might not be exhaustive.


  • MockSimilarEditorsClient.php
  • add file and tests



  • SimilarEditorsClient.php
  • add tests for getEditor and getSimilarEditors to SimilarEditorsClientTest.php

  • SpecialSimilarEditors.php
  • add tests for __construct, execute, onSubmit, onSuccess to SpecialSimilarEditorsTest.php

  • TimeOverlap.php
  • needs file and tests

Event Timeline

@Tchanders This should probably be split up. I was thinking of:

  • SpecialSimilarEditors, ResultsFormatter
  • Editor, TimeOverlap
  • MockSimilarEditorsClient, SimilarEditorsClient
  • ServiceWiring

Thoughts?

STran updated the task description. (Show Details)