Fix margins/padding (VE template dialog)
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	ECohen_WMDE
	May 31 2022, 7:46 AM

Description

Remove margin: https://gerrit.wikimedia.org/r/c/805401

(mobile only) above the template name/description in main editing area (should match the side margins) and above the template search

Add margin: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/805412

(mobile + desktop) bottom of list of params in sidebar (the last item in list should match left side margin)
(mobile + desktop) top of param list ~~when no search bar~~ should match left side margin
Update: Do not add margins when when the last or the first element is a non-indented entry like wikitext or template heading.
Update: Add margins after each param section for multi-part templates.

	Existing	Fixed
Remove margin
mobile only
Add margin
mobile + desktop
mobile + desktop

Outcome

Removing margins in the content pane in mobile:

Screenshot from 2022-06-14 16-01-02.png (916×1 px, 127 KB)

Adding margins to the sidebar:

	Single with checkboxes only:	Single with search bar:	Multi-part template:
desktop
mobile

Details

Subject	Repo	Branch	Lines +/-
Different margins for different last elements in the templates dialog sidebar	mediawiki/extensions/VisualEditor	master	+7 -0
Fixing css in case the last element has text or checkboxes	mediawiki/extensions/VisualEditor	master	+1 -1
Adjust margins in template dialog sidebar	mediawiki/extensions/VisualEditor	master	+17 -0
Adjust margin in mobile template dialog	mediawiki/extensions/VisualEditor	master	+5 -0

Customize query in gerrit

Related Objects

Mentioned Here: T300710: Improve no parameter dialog state

Event Timeline

ECohen_WMDE created this task.May 31 2022, 7:46 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2022, 7:46 AM

ECohen_WMDE moved this task from Backlog to Ready for pickup on the WMDE-Templates-FocusArea board.May 31 2022, 7:46 AM

ECohen_WMDE renamed this task from Remove extra margin on mobile (VE dialog) to Fix margins on mobile (VE dialog).May 31 2022, 8:02 AM

ECohen_WMDE updated the task description. (Show Details)

Maintenance_bot added a project: VisualEditor.May 31 2022, 8:29 AM

ECohen_WMDE updated the task description. (Show Details)May 31 2022, 12:08 PM

ECohen_WMDE renamed this task from Fix margins on mobile (VE dialog) to Fix margins/padding (VE dialog).May 31 2022, 12:30 PM

ECohen_WMDE updated the task description. (Show Details)

ECohen_WMDE moved this task from Ready for pickup to Ready for story time on the WMDE-Templates-FocusArea board.May 31 2022, 1:33 PM

Lena_WMDE renamed this task from Fix margins/padding (VE dialog) to Fix margins/padding (VE template dialog).Jun 1 2022, 1:15 PM

• ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Jun 2 2022, 3:45 PM

Lena_WMDE moved this task from Ready for story time to Ready for pickup on the WMDE-Templates-FocusArea board.Jun 8 2022, 11:16 AM

thiemowmde set the point value for this task to 3.Jun 9 2022, 12:51 PM

lilients_WMDE claimed this task.Jun 14 2022, 10:38 AM

lilients_WMDE added projects: WMDE-TechWish-Sprint-2022-06-08, Unplanned-Sprint-Work.

lilients_WMDE moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.

lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-06-08 board.

Change 805401 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/VisualEditor@master] Adjust margin in mobile template dialog

https://gerrit.wikimedia.org/r/805401

gerritbot added a project: Patch-For-Review.Jun 14 2022, 2:54 PM

Removing one requirement because it's confirmed that this is the OOUI default

lilients_WMDE updated the task description. (Show Details)Jun 14 2022, 3:27 PM

lilients_WMDE updated the task description. (Show Details)Jun 14 2022, 3:32 PM

lilients_WMDE updated the task description. (Show Details)Jun 14 2022, 3:39 PM

Change 805412 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/VisualEditor@master] Adjust padding in template dialog sidebar

https://gerrit.wikimedia.org/r/805412

lilients_WMDE updated the task description. (Show Details)Jun 15 2022, 1:57 PM

lilients_WMDE moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-06-08 board.

lilients_WMDE updated the task description. (Show Details)Jun 15 2022, 2:03 PM

Change 805401 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Adjust margin in mobile template dialog

https://gerrit.wikimedia.org/r/805401

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jun 16 2022, 1:00 PM

@lilients_WMDE spacing between the templates/wikitext headers for multi-part look good to me. The additional spacing at the top of the checkmarks looks good. I assume it's the same at the button of a long list now too? When I look on beta, it's not yet updated there and can't check.

What is strange is that on beta the space at the top of the content-side template header is gone (correctly) but in your screenshots it is still there?
Here is a screenshot from beta with the correct spacing, can you confirm this is still the case?
{F35249267}

Change 805412 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Adjust margins in template dialog sidebar

https://gerrit.wikimedia.org/r/805412

Was checking on beta and the changes seem to be there except the spacing above the content-side template header is still there (as mentioned above) and I noticed an additional spacing issue:

In multi-part template content, one of the templates has no params and the description (added in T300710) is now overlapping with the name. Padding needs to be added back. {F35255693}

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2022, 8:30 AM

lilients_WMDE moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-06-08 board.Jun 20 2022, 8:51 AM

Found a regression we should fix. Transclusion with a template without parameters and template with parameters:

Margin Regression.png (596×240 px, 22 KB)

WMDE-Fisch attached a referenced file: F35255871: Margin Regression.png. (Show Details)Jun 20 2022, 9:34 AM

lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-06-08 board.Jun 20 2022, 9:37 AM

Another regression, possibly the same bug as above:

Change 806869 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/VisualEditor@master] Fixing css in case the last element has text or checkboxes

https://gerrit.wikimedia.org/r/806869

gerritbot added a project: Patch-For-Review.Jun 20 2022, 10:25 AM

lilients_WMDE moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-06-08 board.Jun 20 2022, 10:26 AM

WMDE-Fisch attached a referenced file: F35256002: image.png. (Show Details)Jun 20 2022, 11:37 AM

Change 806869 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fixing css in case the last element has text or checkboxes

https://gerrit.wikimedia.org/r/806869

Change 806902 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/VisualEditor@master] Different margins for different last elements in the templates dialog sidebar

https://gerrit.wikimedia.org/r/806902

awight moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-06-08 board.Jun 20 2022, 2:39 PM

Change 806902 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Different margins for different last elements in the templates dialog sidebar

https://gerrit.wikimedia.org/r/806902

awight moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-06-08 board.Jun 21 2022, 8:09 AM

lilients_WMDE removed lilients_WMDE as the assignee of this task.Jun 21 2022, 8:10 AM

lilients_WMDE subscribed.

thiemowmde closed this task as Resolved.Jun 22 2022, 8:23 AM

thiemowmde claimed this task.

	F35243788: Screenshot from 2022-06-15 15-52-52.png
	Jun 15 2022, 1:57 PM

	F35243776: Screenshot from 2022-06-15 15-39-02.png
	Jun 15 2022, 1:57 PM

	F35243774: Screenshot from 2022-06-15 15-38-49.png
	Jun 15 2022, 1:57 PM

Fix margins/padding (VE template dialog)Closed, ResolvedPublic3 Estimated Story PointsActions