TypeError: window.print is not a function
Closed, ResolvedPublicBUG REPORT
Actions

Description

Noticed this error in logstash. It seems that some UAs do not support print. Thus throwing a TypeError when this function is called from: resources/src/mediawiki.page.ready/ready.js or minerva's resources/skins.minerva.scripts/downloadPageAction.js

Observer for UA: Mozilla/5.0 (Android 10; Mobile; rv:91.0) Gecko/91.0 Firefox/91.0

Error rate: 68 every 7 days
https://logstash.wikimedia.org/goto/e4f97610998e04be09b3f20f8c0cecf8

Details

	Subject	Repo	Branch	Lines +/-
	Don't show download button if there's no window.print	mediawiki/skins/MinervaNeue	master	+6 -1

Customize query in gerrit

Event Timeline

TheDJ created this task.May 31 2022, 9:31 AM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptMay 31 2022, 9:31 AM

I can confirm some browsers disobey the spec here and leave it undefined. I thought we were checking that but I guess not.

Jdlrobson triaged this task as Low priority.Jun 1 2022, 9:11 PM

Jdlrobson added a project: patch-welcome.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Wikimedia-production-error.

Jdlrobson moved this task from Incoming to Needs Prioritization (Tech) on the Web-Team-Backlog board.

Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog.

Jdlrobson moved this task from Backlog to Future Unplanned on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jun 6 2022, 7:26 PM

Jdlrobson added a project: good first task.

Krinkle moved this task from Untriaged to May 2022 on the Wikimedia-production-error board.Jun 7 2022, 9:58 PM

Jdlrobson moved this task from Future Unplanned to Tracking (Temporarily) on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jul 19 2022, 5:59 PM

Jdlrobson removed a project: Web-Team-Backlog (Needs Prioritization (Tech)).Jul 21 2022, 11:51 PM

Change 883251 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/skins/MinervaNeue@master] Don't show download button if there's no window.print

https://gerrit.wikimedia.org/r/883251

gerritbot added a project: Patch-For-Review.Jan 24 2023, 6:17 PM

Change 883251 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Don't show download button if there's no window.print

https://gerrit.wikimedia.org/r/883251

Maintenance_bot removed a project: Patch-For-Review.Jan 26 2023, 6:31 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Jan 26 2023, 7:00 PM

TheDJ closed this task as Resolved.Jan 26 2023, 8:53 PM

TheDJ assigned this task to Ammarpad.

TypeError: window.print is not a functionClosed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

TypeError: window.print is not a function
Closed, ResolvedPublicBUG REPORT
Actions