Page MenuHomePhabricator

Restrict SimilarEditors to work with the same wikis that the Similarusers service works with
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

The Similarusers service only works with English Wikipedia, for now.

The SimilarEditors extension is a MediaWiki interface to the Similarusers service, for the purpose of gathering feedback.

There is a plan to generalise the Similarusers service to other wikis, and gather feedback via SimilarEditors. Until the service is updated, however, SimilarEditors should also be restricted to English Wikipedia.

Example of the problem we want to avoid

We are about to deploy SimilarEditors to the beta cluster. Once we do:

  • The user input will only accept IP addresses or users that exist on that beta wiki. (This doesn't make sense, because the service will only have data for English Wikipedia users.)
  • When results are returned, the results table will create links to user pages on that wiki. (This doesn't make sense, because any results would be for English Wikipedia users.)

(Though when we first deploy to beta, we will not connect to the real Similarusers service; instead we will return mock results. That means we will avoid the above issues, but won't be able to test with the real service.)

Acceptance criteria

Before we do configure beta to use the real Similarusers service, we should do the following:

  • Allow any user to be entered in the user input (ideally we would allow any user that exists on English Wikipedia, but I don't think that complexity is necessary for this temporary change)
  • In the results table, link to user pages on English Wikipedia
  • Where we make these changes, comment that they are temporary until the service is updated, with a reference to T309675

This will allow SimilarEditors to use the Similarusers service in our testing environments as well as on English Wikipedia.

Event Timeline

ARamirez_WMF renamed this task from Restrict SimilarEditors to work with the same wikis that the Similarusers works with to Restrict SimilarEditors to work with the same wikis that the Similarusers service works with.May 31 2022, 5:53 PM

Change 802205 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/SimilarEditors@master] Make SimilarEditors testable on beta

https://gerrit.wikimedia.org/r/802205

Change 802205 merged by jenkins-bot:

[mediawiki/extensions/SimilarEditors@master] Make SimilarEditors testable on beta

https://gerrit.wikimedia.org/r/802205

  • Allow any user to be entered in the user input (ideally we would allow any user that exists on English Wikipedia, but I don't think that complexity is necessary for this temporary change)

Although the username input field will still perform a search for existing user, you can still enter any input into that form.

  • In the results table, link to user pages on English Wikipedia

Here is how the results look now.

interwiki_results.png (617×1 px, 71 KB)

The username links take you to https://en.wikipedia.org.

  • Where we make these changes, comment that they are temporary until the service is updated, with a reference to T309675

Looking through gerrit, we appear to have done this.

Test environment: local docker Similar Editors 0.0.0 (c9fc014) 21:27, 7 June 2022.