Merge `mutate` and `resolveFunctionCallsAndReferences` into `ZWrapper` Class
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmassaro
	May 31 2022, 3:58 PM

Description

This has many benefits, including not having to mutate the underlying ZObject. This will also make it easier to reason about scopes.

Details

	Subject	Repo	Branch	Lines +/-
	Make mutate and resolveFunctionCallsAndReferences members of ZWrapper. This will enable us better to control scopes.	mediawiki/services/function-orchestrator	master	+321 -304

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• AAssaf	T309195 Wrong result due to dynamic scoping in function calls
		Resolved		cmassaro	T309636 Merge `mutate` and `resolveFunctionCallsAndReferences` into `ZWrapper` Class

Event Timeline

cmassaro created this task.May 31 2022, 3:58 PM

cmassaro claimed this task.May 31 2022, 4:12 PM

cmassaro added a project: function-orchestrator.

Jdforrester-WMF added a project: Abstract Wikipedia Fix-It tasks.May 31 2022, 4:49 PM

• AAssaf subscribed.May 31 2022, 7:01 PM

Change 801833 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Make mutate and resolveFunctionCallsAndReferences members of ZWrapper. This will enable us better to control scopes.

https://gerrit.wikimedia.org/r/801833

gerritbot added a project: Patch-For-Review.Jun 1 2022, 6:38 PM

Change 801833 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Make mutate and resolveFunctionCallsAndReferences members of ZWrapper. This will enable us better to control scopes.

https://gerrit.wikimedia.org/r/801833

cmassaro mentioned this in rMSFOa723e74fb3c7: Make mutate and resolveFunctionCallsAndReferences members of ZWrapper. This….Jun 2 2022, 8:23 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 2 2022, 8:29 PM

DVrandecic moved this task from To triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Jun 7 2022, 6:41 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.

Jdforrester-WMF closed this task as Resolved.Jun 7 2022, 6:41 PM

• AAssaf added a parent task: T309195: Wrong result due to dynamic scoping in function calls.Jun 8 2022, 8:52 PM