Maniphest T309637

Add tests for MockSimilarEditorsClient and SimilarEditorsClient
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	STran
	May 31 2022, 4:12 PM

Tags

Referenced Files

None

Subscribers

Description

Add tests for:

MockSimilarEditorsClient->getEditor
MockSimilarEditorsClient->getSimilarEditors
SimilarEditorsClient->getEditor
SimilarEditorsClient->getSimilarEditors

Notes

See https://doc.wikimedia.org/cover-extensions/SimilarEditors/MockSimilarEditorsClient.php.html and https://doc.wikimedia.org/cover-extensions/SimilarEditors/SimilarEditorsClient.php.html

Details

	Subject	Repo	Branch	Lines +/-
	Add tests for MockSimilarEditorsClient and SimilarEditorsClient	mediawiki/extensions/SimilarEditors	master	+150 -7

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T309579 Improve SimilarEditors test coverage
		Resolved		• TThoabala	T309637 Add tests for MockSimilarEditorsClient and SimilarEditorsClient

Event Timeline

STran created this task.May 31 2022, 4:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2022, 4:12 PM

STran added a parent task: T309579: Improve SimilarEditors test coverage.May 31 2022, 4:13 PM

STran updated the task description. (Show Details)

ARamirez_WMF set the point value for this task to 3.May 31 2022, 5:44 PM

ARamirez_WMF moved this task from Untriaged to AHaT Sprint 9: The Beret on the Anti-Harassment board.

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 9: The Beret); removed Anti-Harassment.

• TThoabala claimed this task.May 31 2022, 5:50 PM

Change 802755 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/SimilarEditors@master] Add tests for MockSimilarEditorsClient and SimilarEditorsClient

https://gerrit.wikimedia.org/r/802755

gerritbot added a project: Patch-For-Review.Jun 3 2022, 11:35 AM

• TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 9: The Beret) board.Jun 5 2022, 8:30 PM

• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 9: The Beret) board.

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In progress on the Similarusers board.Jun 13 2022, 2:25 PM

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 10: The Mokorotlo); removed Anti-Harassment (AHaT Sprint 9: The Beret).Jun 14 2022, 5:01 PM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.Jun 14 2022, 5:02 PM

Tchanders moved this task from Code Review 🔍 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.Jun 17 2022, 1:04 PM

Change 802755 merged by jenkins-bot:

[mediawiki/extensions/SimilarEditors@master] Add tests for MockSimilarEditorsClient and SimilarEditorsClient

https://gerrit.wikimedia.org/r/802755

• TThoabala mentioned this in rESIE795fe67dc8dc: Add tests for MockSimilarEditorsClient and SimilarEditorsClient.Jun 17 2022, 1:07 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 17 2022, 1:30 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jun 17 2022, 2:00 PM

Tchanders moved this task from In progress to Done on the Similarusers board.Jun 21 2022, 2:15 PM

• Niharika closed this task as Resolved.Jul 26 2022, 2:13 PM