Page MenuHomePhabricator
Create Task
Maniphest T309638

Add tests for SpecialSimilarEditors and ResultsFormatter
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Add or document tests for:

  • SpecialSimilarEditors->__construct
  • SpecialSimilarEditors->execute
  • SpecialSimilarEditors->onSubmit
  • SpecialSimilarEditors->onSuccess
  • ResultsFormatter->formatRowProperty

See:
https://doc.wikimedia.org/cover-extensions/SimilarEditors/SpecialSimilarEditors.php.html
https://doc.wikimedia.org/cover-extensions/SimilarEditors/ResultsFormatter.php.html

Details

SubjectRepoBranchLines +/-
Add tests for ResultsFormattermediawiki/extensions/SimilarEditorsmaster+59 -0
Add tests for SpecialSimilarEditors and ResultsFormattermediawiki/extensions/SimilarEditorsmaster+117 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

STran created this task.May 31 2022, 4:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2022, 4:16 PM
STran added a parent task: T309579: Improve SimilarEditors test coverage.May 31 2022, 4:16 PM
ARamirez_WMF set the point value for this task to 5.May 31 2022, 5:48 PM
ARamirez_WMF moved this task from Untriaged to AHaT Sprint 9: The Beret on the Anti-Harassment board.
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 9: The Beret); removed Anti-Harassment.
• TThoabala claimed this task.Jun 5 2022, 8:44 PM
• TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 9: The Beret) board.Jun 8 2022, 8:30 AM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In progress on the Similarusers board.Jun 13 2022, 2:25 PM
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 10: The Mokorotlo); removed Anti-Harassment (AHaT Sprint 9: The Beret).Jun 14 2022, 5:00 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.Jun 14 2022, 5:00 PM
gerritbot added a comment.Jun 16 2022, 6:29 PM

Change 806275 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/SimilarEditors@master] Add tests for ResultsFormatter

https://gerrit.wikimedia.org/r/806275

gerritbot added a project: Patch-For-Review.Jun 16 2022, 6:29 PM
gerritbot added a comment.Jun 21 2022, 10:21 AM

Change 807089 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/SimilarEditors@master] Add tests for SpecialSimilarEditors and ResultsFormatter

https://gerrit.wikimedia.org/r/807089

• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.Jun 25 2022, 1:03 AM
Tchanders moved this task from Code Review 🔍 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.Jun 28 2022, 2:09 PM
gerritbot added a comment.Jun 28 2022, 2:09 PM

Change 807089 merged by jenkins-bot:

[mediawiki/extensions/SimilarEditors@master] Add tests for SpecialSimilarEditors and ResultsFormatter

https://gerrit.wikimedia.org/r/807089

• TThoabala mentioned this in rESIE27c390478510: Add tests for SpecialSimilarEditors and ResultsFormatter.Jun 28 2022, 2:10 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 11 2022, 8:02 PM
• Niharika closed this task as Resolved.Jul 26 2022, 2:13 PM
gerritbot added a comment.Feb 7 2024, 10:21 AM

Change 806275 abandoned by Dreamy Jazz:

[mediawiki/extensions/SimilarEditors@master] Add tests for ResultsFormatter

Reason:

Associated task has been closed.

https://gerrit.wikimedia.org/r/806275

Maintenance_bot removed a project: Patch-For-Review.Feb 7 2024, 10:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL