Page MenuHomePhabricator
Create Task
Maniphest T309639

Add tests for TimeOverlap
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Add tests for:

  • TimeOverlap->__construct
  • TimeOverlap->getCosineSimilarity
  • TimeOverlap->getLevel

See https://doc.wikimedia.org/cover-extensions/SimilarEditors/TimeOverlap.php.html

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add test coverage for TimeOverlapmediawiki/extensions/SimilarEditorsmaster+21 -0
Check for exact values in TimeOverlapTestmediawiki/extensions/SimilarEditorsmaster+2 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclinedNoneT309579 Improve SimilarEditors test coverage
 Resolved• AGueyteT309639 Add tests for TimeOverlap

Event Timeline

STran created this task.May 31 2022, 4:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2022, 4:18 PM
STran added a parent task: T309579: Improve SimilarEditors test coverage.May 31 2022, 4:18 PM
ARamirez_WMF set the point value for this task to 2.May 31 2022, 5:51 PM
ARamirez_WMF moved this task from Untriaged to AHaT Sprint 9: The Beret on the Anti-Harassment-Team board.
ARamirez_WMF edited projects, added Anti-Harassment-Team (AHaT Sprint 9: The Beret); removed Anti-Harassment-Team.
• AGueyte claimed this task.Jun 2 2022, 4:32 PM
• AGueyte moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (AHaT Sprint 9: The Beret) board.Jun 2 2022, 5:56 PM
gerritbot added a comment.Jun 2 2022, 8:59 PM

Change 802635 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/SimilarEditors@master] Add test coverage for TimeOverlap

https://gerrit.wikimedia.org/r/802635

gerritbot added a project: Patch-For-Review.Jun 2 2022, 8:59 PM
• AGueyte moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (AHaT Sprint 9: The Beret) board.Jun 6 2022, 8:20 PM
gerritbot added a comment.Jun 9 2022, 7:44 PM

Change 802635 merged by jenkins-bot:

[mediawiki/extensions/SimilarEditors@master] Add test coverage for TimeOverlap

https://gerrit.wikimedia.org/r/802635

• AGueyte mentioned this in rESIE43b06bc631c7: Add test coverage for TimeOverlap.Jun 9 2022, 7:47 PM
• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (AHaT Sprint 9: The Beret) board.Jun 9 2022, 7:50 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).Jun 9 2022, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 9 2022, 8:30 PM
gerritbot added a comment.Jun 10 2022, 1:56 PM

Change 804586 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/SimilarEditors@master] Check for exact values in TimeOverlapTest

https://gerrit.wikimedia.org/r/804586

gerritbot added a project: Patch-For-Review.Jun 10 2022, 1:56 PM
Tchanders moved this task from QA/Testing 🐞 to Code Review 🔍 on the Anti-Harassment-Team (AHaT Sprint 9: The Beret) board.Jun 10 2022, 2:00 PM
• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (AHaT Sprint 9: The Beret) board.Jun 10 2022, 2:08 PM
gerritbot added a comment.Jun 10 2022, 2:27 PM

Change 804586 merged by jenkins-bot:

[mediawiki/extensions/SimilarEditors@master] Check for exact values in TimeOverlapTest

https://gerrit.wikimedia.org/r/804586

Tchanders mentioned this in rESIE3ff635c0c12c: Check for exact values in TimeOverlapTest.Jun 10 2022, 2:28 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 10 2022, 2:30 PM
Tchanders moved this task from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment-Team (AHaT Sprint 9: The Beret) board.Jun 10 2022, 2:44 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Done on the Similarusers board.Jun 13 2022, 2:24 PM
Niharika closed this task as Resolved.Jul 26 2022, 2:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits