Page MenuHomePhabricator

Make it possible for everyone who can access Special:AbuseFilter to search rules
Open, Needs TriagePublic

Description

The search bar on Special:AbuseFilter is restricted to those who can view private filters, and has always been since its introduction. I'm not sure why this has to be the case, and I think we could show it to everyone, like the other search options.

Event Timeline

@matej_suchanek @Huji Do you think this proposal makes sense, or am I missing something obvious?

@matej_suchanek @Huji Do you think this proposal makes sense, or am I missing something obvious?

As long as we don't let users that cannot see private filters search in these, it should be fine I guess.

I just realized that if you can view Special:AbuseFilter but not private filters, every private filter will still be on the list, and you'll be able to see its information (except for hit count). The filter's name is even clickable, although you get a permission error if you try to open it. So if we make the search bar usable to everyone, they'd be able to figure out what a certain private filter may or may not contain.

I think a better approach would be to hide private filters *completely* from Special:AbuseFilter and the API. Otherwise, LTAs can see how many filters are there that target them, when they were last edited, what their actions are, etc. In fact, I think that the concept of "private filter" should refer to the whole filter, not just its rules. At that point we can make the search available to everyone; if you're not allowed to view private filters, they wouldn't appear anyway.

Filed T309693 for the private filters thing.