Maniphest T309712

Dismiss 'Try Content Translation' popup
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	zeljkofilipin
	Jun 1 2022, 1:51 PM

Tags

Referenced Files

	F35196369: pass.png
	Jun 1 2022, 1:51 PM

	F35196372: fail.png
	Jun 1 2022, 1:51 PM

Subscribers

Description

While working on T296187: Selenium Tests for VisualEditor, @EAkinloose and I have created several commits, including 801729.

Several Jenkins jobs run for the commit, including:

quibble-vendor-mysql-php72-selenium-docker (122169)
wmf-quibble-selenium-php72-docker (153733)

Everything is fine with quibble-vendor-mysql-php72-selenium-docker but wmf-quibble-selenium-php72-docker fails because Try Content Translation popup is displayed over Save your changes popup.

Screenshot for passing quibble-vendor-mysql-php72-selenium-docker but wmf-quibble-selenium-php72-docker job (video).

pass.png (916×1 px, 356 KB)

Screenshot for failing wmf-quibble-selenium-php72-docker job (video).

fail.png (911×1 px, 351 KB)

The test fails because Save page button is covered by Try Content Translation popup.

Other popups that used to cause trouble are disable by URL parameters vehidebetadialog=1 and hidewelcomedialog=1. Is there an URL parameter to hide Try Content Translation popup?

Details

	Subject	Repo	Branch	Lines +/-
	Allow beta invitation popup to be suppressed with query string param	mediawiki/extensions/ContentTranslation	master	+5 -2
	WIP: selenium: Enable Content Editable should save an edit	mediawiki/extensions/VisualEditor	master	+2 -3
	selenium: Better assertion after saving the page	mediawiki/extensions/VisualEditor	master	+6 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T284512 [EPIC] Empower others to develop new, and extend existing, editing experiences
		Open		None	T299620 Implement automated testing for core editing functionality
		Open		EAkinloose	T296187 Selenium Tests for VisualEditor
		Resolved		zeljkofilipin	T309712 Dismiss 'Try Content Translation' popup

Event Timeline

zeljkofilipin created this task.Jun 1 2022, 1:51 PM

zeljkofilipin updated the task description. (Show Details)

zeljkofilipin updated the task description. (Show Details)Jun 1 2022, 1:53 PM

zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.

zeljkofilipin added a parent task: T296187: Selenium Tests for VisualEditor.Jun 2 2022, 1:48 PM

zeljkofilipin mentioned this in T296187: Selenium Tests for VisualEditor.

Change 801729 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/extensions/VisualEditor@master] selenium: Better assertion after saving the page

https://gerrit.wikimedia.org/r/801729

gerritbot added a project: Patch-For-Review.Jun 2 2022, 1:52 PM

Nikerabbit moved this task from Needs Triage to Check & Move on the ContentTranslation board.Jun 6 2022, 11:21 AM

zeljkofilipin moved this task from Deep work 🌊 to Q4 👔 on the User-zeljkofilipin board.Jun 8 2022, 12:16 PM

Change 801729 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] selenium: Better assertion after saving the page

https://gerrit.wikimedia.org/r/801729

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).Jun 8 2022, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 8 2022, 3:30 PM

Change 804328 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/ContentTranslation@master] Allow beta invitation popup to be suppressed with query string param

https://gerrit.wikimedia.org/r/804328

gerritbot added a project: Patch-For-Review.Jun 9 2022, 2:21 PM

The above patch allows the cx popup to be hidden with cxhidebetapopup=1

@Esanders Thanks!

Change 804328 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Allow beta invitation popup to be suppressed with query string param

https://gerrit.wikimedia.org/r/804328

Maintenance_bot removed a project: Patch-For-Review.Jun 13 2022, 9:30 AM

zeljkofilipin claimed this task.Jun 13 2022, 11:37 AM

zeljkofilipin moved this task from Waiting 🏹 to Deep work 🌊 on the User-zeljkofilipin board.

Change 805110 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/extensions/VisualEditor@master] WIP: selenium: Enable Content Editable should save an edit

https://gerrit.wikimedia.org/r/805110

gerritbot added a project: Patch-For-Review.Jun 13 2022, 11:39 AM

Change 805110 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] WIP: selenium: Enable Content Editable should save an edit

https://gerrit.wikimedia.org/r/805110

zeljkofilipin closed this task as Resolved.Jun 13 2022, 1:21 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 13 2022, 1:30 PM