Page MenuHomePhabricator

MenuItem links are blue again
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Visit the patchdemo instance for the Vector patch to introduce Codex + the latest main branch of Codex
  • Type something into the input

What happens?:

Title text is blue instead of dark gray:

image.png (954×748 px, 124 KB)

What should have happened instead?:

Title text should be dark gray (and primary blue on active)

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Codex main branch

Related Objects

StatusSubtypeAssignedTask
DuplicateNone
Resolved Sarai-WMDE
ResolvedBUG REPORTAnneT

Event Timeline

Change 802183 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] MenuItem, styles: Fix link style overrides

https://gerrit.wikimedia.org/r/802183

Test wiki created on Patch demo by Roan Kattouw (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/ac87714421/w/

Also created a Codex documentation site:
https://patchdemo.wmflabs.org/wikis/ac87714421/w/build/codex/demos

Change 802183 merged by jenkins-bot:

[design/codex@main] MenuItem, TypeaheadSearch, styles: Fix link style overrides

https://gerrit.wikimedia.org/r/802183

Looking good! Checked in Firefox v100 and 99, Chrome v101 and 102 and Safari 15.5. In all cases on MacOS Monterrey.

Test wiki on Patch demo by Roan Kattouw (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/ac87714421/w/