Change 815214 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/core@master] [WIP] Update the "results from other language wiki" section

https://gerrit.wikimedia.org/r/815214

Change 815214 merged by jenkins-bot:

[mediawiki/core@master] Update the "results from other language wiki" section

https://gerrit.wikimedia.org/r/815214

Change 830613 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/core@master] Use container div instead of styling elements individually

https://gerrit.wikimedia.org/r/830613

The project-localized-name-* messages are not designed to be used in a sentence context. They are not inflected and letter casing is not for the sentence context.

This is the reason why there are separate sets of messages, for example search-interwiki-results-*, for different use cases to enable proper localisation. I suggest to evaluate whether the project name must be named in this context, and if so, create a new set of messages. The Language team is happy to advice on i18n issues.

Test wiki created on Patch demo by Seddon using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/2454533c92/w

Also created an OOUI Demos page:
https://patchdemo.wmflabs.org/wikis/2454533c92/w/build/ooui/demos

Also created a Codex documentation site:
https://patchdemo.wmflabs.org/wikis/2454533c92/w/build/codex/demos

Change 830613 merged by jenkins-bot:

[mediawiki/core@master] Use container divs instead of styling elements individually

https://gerrit.wikimedia.org/r/830613

For @Sneha quick review:
(1) Desktop

Proposed design	Special:Search on wmf.1

Notes:

• "Results 20 of ..." the message has never been shown for this type of searches (see the Current layout in the task description).
• (very minor) The quotation marks wrapping - the opening quotes are left on line and the whole word (with closing quotes) is on the next line. Interesting, that the issue seems to be specific to CJK language - the search term consisting of four elements - オジブワ (I also checked zhwiki for four-element words) will always produce that minor issue with marooned quotation marks.

(2) Mobile (waiting on T318197: [QA task] Compare mobile Special:Search scrolling on wmf.1 and wmf.2 - Resolved)

Mobile Figma mockup	Mobile wmf.2

Notes:

• the following element is not displayed on mobile

<p class="mw-search-createlink">
<i>The page "<a href="/w/index.php?title=%E3%82%AA%E3%82%B8%E3%83%96%E3%83%AF&amp;action=edit&amp;redlink=1" class="new" title="オジブワ (page does not exist)">オジブワ</a>" does not exist. You can <a href="/wiki/Wikipedia:Article_wizard" title="Wikipedia:Article wizard">create a draft and submit it for review</a>, or you may create the page "<a href="/w/index.php?title=%E3%82%AA%E3%82%B8%E3%83%96%E3%83%AF&amp;action=edit&amp;redlink=1" class="new" title="オジブワ (page does not exist)">オジブワ</a>" directly.</i></p>

• "Showing results from ..." label (font-size 1.5 em) looks bigger than in the mobile mockup. Do we have mobile font-size base as 16px instead of 14px on desktop?
• The horizontal line under "Showing results from ..." is not present on mobile. The line is present on the desktop.

Thanks @Etonkovidova for outlining the issues above. Below are my responses.

Desktop:
Looks good to me overall. No changes required from my end.

• I was not aware that we don't show page 1 of 20 indication for these type of results. We can leave it as is.
• The marooned quotation mark would be good to fix but not necessary if it involves lot of work to finish this ticket as this case is not that frequent

Mobile:

• The create article message was something I added on mobile. It is currently not there. And I believe we would need a new ticket to add it. I remember talking about it @CBogen do you remember if we already have a ticker for this? Regardless we don't have to do add it as part of this ticket.
• The title "Showing results from...." should be fixed as the font looks a lot bigger than specified in design.
• Yes the horizontal line should be added
• Also the results are not left aligned with the title so that needs to be fixed as well.

In T309745#8273606, @Sneha wrote:

Mobile:

• The create article message was something I added on mobile. It is currently not there. And I believe we would need a new ticket to add it. I remember talking about it @CBogen do you remember if we already have a ticker for this? Regardless we don't have to do add it as part of this ticket.

Yes, this is covered in T316400 in the backlog.

• The title "Showing results from...." should be fixed as the font looks a lot bigger than specified in design.
• Yes the horizontal line should be added
• Also the results are not left aligned with the title so that needs to be fixed as well.

@Seddon I'm moving this back to "doing" for the fixes. Feel free to assign to another engineer.

In T309745#8217467, @Nikerabbit wrote:

The project-localized-name-* messages are not designed to be used in a sentence context. They are not inflected and letter casing is not for the sentence context.

Yes, this needs to be addressed. I stumbled onto this when updating translations and I can confirm that this cannot be translated so that the result would be gramatically correct and read naturally, or without messing up translations in other contexts. I also wonder if this message change is really needed.

Double-checked translation for RU wiki (see the shot). Indeed, project-localized-name-* cannot be used with correct grammar in the sentence ''There were no results matching the query in <Language> wiki" because of "in" preposition ( at least for wikis from Cyrillic group ). I'm thinking about two approaches of solving this.

1. The easiest: keep wiki name at the beginning of the sentence, so result will be something like "English Wikipedia doesn't have articles named オジブワ"
2. Harder: create a new set of messages as has been propped by @Nikerabbit

Would keeping it aligned with "from X Wikipedia" work? @Nikerabbit

In T309745#8363313, @Seddon wrote:

Would keeping it aligned with "from X Wikipedia" work? @Nikerabbit

If you mean X would be replaced with language name, nope.

Example:

As you can see, the changes to the language name required for the context are drastic. This cannot be done automatically in Finnish and in many other languages.

In T309745#8363161, @vadim-kovalenko wrote:

Indeed, project-localized-name-* cannot be used with correct grammar in the sentence ''There were no results matching the query in <Language> wiki" because of "in" preposition ( at least for wikis from Cyrillic group ). I'm thinking about two approaches of solving this.

1. The easiest: keep wiki name at the beginning of the sentence, so result will be something like "English Wikipedia doesn't have articles named オジブワ"

@Nikerabbit @Sneha do you have any concerns with this proposal?

In T309745#8366436, @CBogen wrote:

1. The easiest: keep wiki name at the beginning of the sentence, so result will be something like "English Wikipedia doesn't have articles named オジブワ"

... do you have any concerns with this proposal?

This may be sufficient in some languages, but natural word order in languages is different, and in some languages project name still needs to be inflected even if it's at the beginning of the sentence. So I think genrally this proposal wouldn't change much.

But why was the wording changed in the first place? Why "in this site" or something similar wasn't sufficient?

In T309745#8366724, @Pikne wrote:

In T309745#8366436, @CBogen wrote:

1. The easiest: keep wiki name at the beginning of the sentence, so result will be something like "English Wikipedia doesn't have articles named オジブワ"

... do you have any concerns with this proposal?

This may be sufficient in some languages, but natural word order in languages is different, and in some languages project name still needs to be inflected even if it's at the beginning of the sentence. So I think genrally this proposal wouldn't change much.

But why was the wording changed in the first place? Why "in this site" or something similar wasn't sufficient?

I think it's fair to aim for greater than sufficient :)

In T309745#8365561, @Nikerabbit wrote:

In T309745#8363313, @Seddon wrote:

Would keeping it aligned with "from X Wikipedia" work? @Nikerabbit

If you mean X would be replaced with language name, nope.

Example:

	English translation	Finnish translation
language name	English	englanti
message	From English Wikipedia	Englanninkielisestä Wikipediasta

As you can see, the changes to the language name required for the context are drastic. This cannot be done automatically in Finnish and in many other languages.

Does this mean that the current wording for multilingual results is similarly less than ideal? "showing results from x"

In T309745#8366733, @Seddon wrote:

I think it's fair to aim for greater than sufficient :)

Sure. It's just that due to translation issues current wording seems less sufficient than previous one. I think return to status quo may be considered an improvement as long as there isn't a better solution.

Does this mean that the current wording for multilingual results is similarly less than ideal? "showing results from x"

I think these are generally fine as associated messages (search-interwiki-results-*) include the complete sentence including project name. Similar solution was already suggested above (T309745#8217467).

It's just a little tedious to translate similar sets of messages for each project, and so I think it's worth to evaluate if it's really needed to include a project name in interface texts like this.

@Sneha, given the above, can we just keep the old copy:

There were no results matching the query in this site.

and remove that acceptance criteria from this ticket, so that we can wrap up the other acceptance criteria and close the ticket?

Sure we can go back to previous copy. The reason for adding the wikipedia name is that it provided better context for why the results from other language wiki is appearing. But it seems too much work for little gain since this case does not happen often. I will update the AC to remove the new copy.

ACs for paddings and underlining seem to be correct now. As for the previous copy of translated message looks like we need to rollback this change:
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/815214/
@SimoneThisDot , what do you think?

@vadim-kovalenko that is the correct assumption. Rolling back that commit should revert the AC above mentioned!

Change 861876 had a related patch set uploaded (by Vadim Kovalenko; author: Vadim Kovalenko):

[mediawiki/core@master] Revert change from I7939e85aca5edf9b8c391b9e3167ac9634708fbf

https://gerrit.wikimedia.org/r/861876

Change 861876 merged by jenkins-bot:

[mediawiki/core@master] Revert change from I7939e85aca5edf9b8c391b9e3167ac9634708fbf

https://gerrit.wikimedia.org/r/861876

QA notes to check on group2:

• Cross-wiki search results are of two types: Cross-project search (also known as interwiki search, sister search, or sister projects search) and Cross-language search.
• Cross-language search is not enabled on all wikis (see TextCat) - currently deployed to the Dutch, English, French, German, Italian, Japanese, Portuguese, Russian, and Spanish Wikipedias.
• Cross-language search has a set of languages for which suggestions will be given - see wgCirrusSearchTextcatLanguages.

Note cross-language search is not enabled in beta cluster, so it's not possible to check such searches there.

Moving to Design QA for @Sneha review - please take a look at what is missing and let me know if split tickets should be filed or if you need more more info:

• two specs from the task description seem to be done
• the placeholder image is not displayed - should it be added? Or there was a change in the specs that I missed? search for オジブワ

Proposed design	wmf.1	wmf.17 - current production

• mobile seems like it needs more work? There is no horizontal line and padding seems doesn't match the mockup.

Mobile Figma mockup	Mobile wmf.2	Mobile wmf.17 - current production
		ruwiki with English UI

Checked on pilot wikis - ptwiki, idwiki, and ruwiki .

• idwiki doesn't have cross-language search enabled
• ptwiki doesn't provide suggestions search terms Japanese ;search in Russian кот баюн gives the following:

• ruwiki - two examples: search for オジブワ and search for Gempa Bumi

@Etonkovidova thx for the screenshots. What is the difference between wmf.1, wmf.2, and wmf.17 (which I assume is the latest) ?

As for showing the thumbnails on desktop I am not sure where we had landed with this. Ideally it is good to have all search results look the same but also it would be good to differentiate these other language results from the main results. @CBogen do you remember the decision on whether we still doing thumbnails for these results? Also are we showing preview for these results. In my mocks for mobile I have arrows indicating there is a preview but implemented version does not. So I am just trying to remember if we had decided otherwise.

In T309745#8520689, @Sneha wrote:

As for showing the thumbnails on desktop I am not sure where we had landed with this. Ideally it is good to have all search results look the same but also it would be good to differentiate these other language results from the main results. @CBogen do you remember the decision on whether we still doing thumbnails for these results? Also are we showing preview for these results. In my mocks for mobile I have arrows indicating there is a preview but implemented version does not. So I am just trying to remember if we had decided otherwise.

We definitely decided not to show search preview for those results (since we don't always have that info). As far as whether we're showing thumbnails, I don't remember -- but if you're happy with it as is, let's not add extra work :)

okay in that case everything looks good @Etonkovidova except that mobile needs to have that line and mobile wmf.2 padding does not look aligned in the margins.

In T309745#8520803, @Sneha wrote:

okay in that case everything looks good @Etonkovidova except that mobile needs to have that line and mobile wmf.2 padding does not look aligned in the margins.

Thx, @Sneha and @CBogen. There is no difference between screenshots for wmf.1 and wmf.2 - they represent the old display of cross-language search.

Moving it to Verify on Production (it's not possible to test in betacluster).

Test wiki on Patch demo by Seddon using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/2454533c92/w/