Page MenuHomePhabricator

TypeError: Cannot read properties of undefined (reading 'dailyLimit')
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
normalized_message
TypeError: Cannot read properties of undefined (reading 'dailyLimit')
exception.trace
Impact
  • When the quality gate limit is reached, the user can proceed to the article but will see a "No suggestions found" dialog (instead of seeing a quality gate-specific dialog on Special:Homepage). For users who have not reached the quality gate limit, the experience is the not impacted.
Notes

Somehow the quality gate data is not exported with the taskset, not sure why.

Event Timeline

mewoph moved this task from Incoming to In Progress on the Growth-Team (Current Sprint) board.
mewoph updated the task description. (Show Details)

This regressed from T308542: Suggested edits: Populate task queue from server-side. Previously the quality gate config is set when the first task is populated. When the logic was changed to be a task queue, the quality gate config was not set.

Change 802855 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] NewcomerTasksStore: update quality gate config when the task queue is set

https://gerrit.wikimedia.org/r/802855

Error
normalized_message
TypeError: this.config.gateConfig[taskType] is undefined
Impact

~70 events in the last couple of days in group2

Error
normalized_message
TypeError: undefined is not an object (evaluating 'this.config.gateConfig[taskType].dailyLimit')
Impact

~22 events in last couple of days in group2

Notes

Adding these two errors here instead of re-opening previous tasks with the same error exception since the cause seems the regression mentioned above. @mewoph can you confirm that these two exceptions will also be fixed with the patch?

Hi @Sgs, the different messages are from different browsers so the fix should address all of them.

Hi @Sgs, the different messages are from different browsers so the fix should address all of them.

Alright. Thank you.

Change 802855 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] NewcomerTasksStore: update quality gate config when the task queue is set

https://gerrit.wikimedia.org/r/802855

Change 804712 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.15] NewcomerTasksStore: update quality gate config when the task queue is set

https://gerrit.wikimedia.org/r/804712

Change 804712 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.15] NewcomerTasksStore: update quality gate config when the task queue is set

https://gerrit.wikimedia.org/r/804712

Change 804712 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.15] NewcomerTasksStore: update quality gate config when the task queue is set

https://gerrit.wikimedia.org/r/804712

@Etonkovidova, @Urbanecm_WMF and I backported this today, so the fix should be everywhere now.

Mentioned in SAL (#wikimedia-operations) [2022-06-13T13:22:56Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.15/extensions/GrowthExperiments/modules/ext.growthExperiments.DataStore/NewcomerTasksStore.js: 67a5352b0bf9f6aa160cc93a42ca22a02aad883a: NewcomerTasksStore: update quality gate config when the task queue is set (T309768) (duration: 03m 41s)

Change 805770 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] NewcomerTasksStore: Check if taskData is set before using

https://gerrit.wikimedia.org/r/805770

hashar added a subscriber: hashar.

Looks like that one has been fixed by @kostajh for 1.39.0-wmf.15 and is not a blocker for 1.39.0-wmf.17