Autocomplete highlighting should ignore trailing space inserted by Android keyboard autocomplete
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	simon04
	Jun 2 2022, 4:39 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

Surf to https://en.m.wikipedia.org/wiki/Main_Page on Android phone
Tab "Search Wikipedia"
Type "Wiki"
Observe that all strings of "Wiki" are highlighted (bold)
From Android keyboard autocompletion, tab suggestion "Wikipedia"
Observe that input field contains "Wikipedia " (including trailing space)
Observe that "Wikipedia" is not highlighted (bold)
Expecting that "Wikipedia" is highlighted
Remove trailing space
Observe that "Wikipedia" is highlighted (bold)

What happens?:

See "Observe that" above.

What should have happened instead?:

See "expecting that" above. Autocomplete highlighting should ignore trailing space inserted by Android keyboard autocomplete.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Firefox Android 100.3.0 (Build #2015881499), 409a30ff0+
AC: 100.0.12, 7b24cbd763
GV: 100.0.2-20220519220738
AS: 91.1.1

QA Results - Prod

AC	Status	Details
1	✅	T309795#9471095

Details

	Subject	Repo	Branch	Lines +/-
	SearchGateway._highlightSearchTerm: trim term	mediawiki/extensions/MobileFrontend	master	+3 -2

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
Resolved		Jdlrobson	T195478 [EPIC] Speed up unit test execution and increase code coverage
Resolved		Jdlrobson	T195482 [EPIC] Review and refactor MobileFrontend components used by Minerva
Open		None	T281930 [EPIC] Migrate MobileFrontend's code to Vue.js and Codex
Declined		None	T212465 [EPIC] None of our View's should exhibit 2 levels of inheritance
Declined	BUG REPORT	Jdlrobson	T289084 MinervaNeue shows 2 search elements when JS is disabled
Open		None	T282473 [GOAL] Use the Codex search widget inside the mobile site
Resolved	BUG REPORT	Edtadros	T309795 Autocomplete highlighting should ignore trailing space inserted by Android keyboard autocomplete

Event Timeline

simon04 created this task.Jun 2 2022, 4:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 2 2022, 4:39 PM

Thanks for the bug report. We are looking to replace the mobile search with a Vue implementation sometime in September.

Jdlrobson added a parent task: T282473: [GOAL] Use the Codex search widget inside the mobile site.Jun 2 2022, 7:58 PM

Jdlrobson moved this task from Backlog to Using Codex in web team products / Skin unification on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jun 6 2022, 7:26 PM

Needs reprioritization.

Jdlrobson moved this task from Incoming to FY2023-24 Q3 Sprint 1 on the Web-Team-Backlog board.Dec 19 2023, 5:51 PM

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 1); removed Web-Team-Backlog.

Jdlrobson moved this task from FY2023-24 Q3 Sprint 1 to FY2023-24 Q3 Sprint 2 on the Web-Team-Backlog board.Jan 4 2024, 12:10 AM

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 2); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 1).

Change 987772 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MobileFrontend@master] SearchGateway._highlightSearchTerm: trim term

https://gerrit.wikimedia.org/r/987772

gerritbot added a project: Patch-For-Review.Jan 4 2024, 1:41 PM

Change 987772 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] SearchGateway._highlightSearchTerm: trim term

https://gerrit.wikimedia.org/r/987772

Adding to next week's sprint for QA

Jdlrobson assigned this task to Edtadros.Jan 4 2024, 11:43 PM

Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 1) board.

Maintenance_bot removed a project: Patch-For-Review.Jan 5 2024, 12:30 AM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ).Jan 5 2024, 1:00 AM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

List of steps to reproduce (step by step, including full links if applicable):

Surf to https://en.m.wikipedia.org/wiki/Main_Page on Android phone
Tab "Search Wikipedia"
Type "Wiki"
✅ AC1: Observe that all strings of "Wiki" are highlighted (bold)

From Android keyboard autocompletion, tab suggestion "Wikipedia"
Observe that input field contains "Wikipedia " (including trailing space)
✅ AC1: Expecting that "Wikipedia" is highlighted

screenshot 211.mov.gif (1×498 px, 350 KB)

Remove trailing space
✅ AC3: Observe that "Wikipedia" is highlighted (bold)

screenshot 212.mov.gif (1×498 px, 814 KB)

Edtadros updated the task description. (Show Details)Jan 18 2024, 10:38 PM

Edtadros mentioned this in T354296: Verify 1.42.0-wmf.13 deployment.Jan 18 2024, 10:40 PM

Jdlrobson closed this task as Resolved.Jan 19 2024, 12:48 AM

Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q3 Sprint 1) board.

Nux mentioned this in T367453: Autocomplete highlighting does not actually highlight matched text.Jun 13 2024, 5:48 PM

	F35200437: Screenshot_20220602-183205.jpg
	Jun 2 2022, 4:39 PM

	F35200434: Screenshot_20220602-182702.jpg
	Jun 2 2022, 4:39 PM

	F35200432: Screenshot_20220602-182655.jpg
	Jun 2 2022, 4:39 PM

	F41698323: screenshot 212.mov.gif
	Jan 18 2024, 10:36 PM

	F41698321: screenshot 211.mov.gif
	Jan 18 2024, 10:36 PM

	F41698318: screenshot 409.png
	Jan 18 2024, 10:36 PM

Autocomplete highlighting should ignore trailing space inserted by Android keyboard autocompleteClosed, ResolvedPublic0 Estimated Story PointsBUG REPORTActions