Page MenuHomePhabricator

SmashPig::queue2civicrm find a completed dlocal payment mark as failed and removed from queue table
Closed, DeclinedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • go to the failmail from june1, and looking for order ID 119142081.1
  • check the transaction from dlocal console, the status is paid
  • check log from frlog, after this transaction been logged to pending table, we get the payment status as failed then remove it from the table, and which causing the failmail as

MISSING_PREDECESSOR Message astropay-2163870568 indicates a pending DB entry with order ID 119142081.1, but none was found. Requeueing.
Source: array (
))

What happens?:
SmashPig::queue2civicrm find a completed dlocal payment mark as failed and removed from queue table

What should have happened instead?:
we should log the request data as debug and then get the correct payment status

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Event Timeline

based on wfan@frlog1001:/srv/archive/frlog1001/logs$ zgrep 119142081 payments-astropay-202206*.gz
we tried twice and got failed all the time, then log this to damage table.
payments-astropay-20220602.gz:Jun 1 05:08:38 payments1006 astropay_gateway: 119142081:119142081.1 Resultswitcher: OK to process Order ID: 119142081.1
payments-astropay-20220602.gz:Jun 1 05:08:38 payments1006 astropay_gateway: 119142081:119142081.1 Clock at findCodeAction: 0 (1654060118.3151)
payments-astropay-20220602.gz:Jun 1 05:08:38 payments1006 astropay_gateway: 119142081:119142081.1 Payment status failed coming back to ResultSwitcher
payments-astropay-20220602.gz:Jun 1 05:08:38 payments1006 astropay_gateway: 119142081:119142081.1 session_resetForNewAttempt: Soft reset, order_id only
payments-astropay-20220602.gz:Jun 1 05:08:38 payments1006 astropay_gateway: 119142081:119142081.1 Pushing transaction to payments-init queue.
payments-astropay-20220602.gz:Jun 1 05:08:38 payments1006 astropay_gateway_trxn: 119142081:119142081.1 "2022-06-01T05:08:38+00:00" "119142081" "Gateway response: " "null"
payments-astropay-20220602.gz:Jun 1 05:08:38 payments1006 astropay_gateway: 119142081:119142081.1 Not sending queue message for status failed.
payments-astropay-20220602.gz:Jun 1 05:08:38 payments1006 astropay_gateway: 119142081:119142081.1 Displaying fail page for failed PaymentResult
payments-astropay-20220602.gz:Jun 1 05:09:58 payments1006 astropay_gateway: 119142081:119142081.1 Resultswitcher: OK to process Order ID: 119142081.1
payments-astropay-20220602.gz:Jun 1 05:09:58 payments1006 astropay_gateway: 119142081:119142081.1 Clock at findCodeAction: 0 (1654060198.6619)
payments-astropay-20220602.gz:Jun 1 05:09:58 payments1006 astropay_gateway: 119142081:119142081.1 Payment status failed coming back to ResultSwitcher
payments-astropay-20220602.gz:Jun 1 05:09:58 payments1006 astropay_gateway: 119142081:119142081.1 session_resetForNewAttempt: Soft reset, order_id only
payments-astropay-20220602.gz:Jun 1 05:09:58 payments1006 astropay_gateway: 119142081:119142081.1 Pushing transaction to payments-init queue.
payments-astropay-20220602.gz:Jun 1 05:09:58 payments1006 astropay_gateway_trxn: 119142081:119142081.1 "2022-06-01T05:09:58+00:00" "119142081" "Gateway response: " "null"
payments-astropay-20220602.gz:Jun 1 05:09:58 payments1006 astropay_gateway: 119142081:119142081.1 Not sending queue message for status failed.
payments-astropay-20220602.gz:Jun 1 05:09:58 payments1006 astropay_gateway: 119142081:119142081.1 Displaying fail page for failed PaymentResult

Change 802595 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Log querystring values for ResultSwitcher

https://gerrit.wikimedia.org/r/802595

Change 802595 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Log querystring values for ResultSwitcher

https://gerrit.wikimedia.org/r/802595

greg triaged this task as Medium priority.Nov 1 2022, 6:12 PM
Aklapper added a subscriber: XenoRyet.

@XenoRyet: Please associate at least one active team/codebase project tag with a task, so people can find a task when looking at project workboards or searching for tasks in certain projects. Thanks.

Ejegg subscribed.

Seems to relate to the old integration, which we're about to remove.