Page MenuHomePhabricator

Use OOUI in Special:CheckUser
Closed, ResolvedPublic

Description

Like in T266586, Special:CheckUser should use OOUI. This would mean updating the form used at the top of Special:CheckUser to use OOUI. Also the CIDR calculator should use OOUI.

Event Timeline

Change 802672 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Use OOUI on Special:CheckUser

https://gerrit.wikimedia.org/r/802672

Change 802672 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Use OOUI on Special:CheckUser

https://gerrit.wikimedia.org/r/802672

The CIDR calculator still needs to be converted to OOUI, but I had difficulty with doing this easily as the text area widget class did not support adding 'cols' to the text area. Will have a look at this later.

Change 802903 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Minor bug fix on OOUI conversion of Special:CheckUser

https://gerrit.wikimedia.org/r/802903

Change 802903 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Minor bug fix for OOUI conversion of Special:CheckUser

https://gerrit.wikimedia.org/r/802903

Change 803372 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Use OOUI in the CIDR calculator and checkuserblock form

https://gerrit.wikimedia.org/r/803372

Change 803372 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Use OOUI in the CIDR calculator and checkuserblock form

https://gerrit.wikimedia.org/r/803372

It appears that the new form doesn't switch the radio button to "Get edits" when I accidentally try to get IP addresses for an IP. The old form would show an error and switch to "Get edits", but the new form just shows the error.

I did not think to test what happens with the checkboxes when using an IP for the "Get IP addresses" option. This is because the OOUI code gets the selected value in the following way:

  • First it tries to look for the value in the POST data (it exists in the example above)
  • If that is not set, it uses the default value which is null if not set.

By telling OOUI to not read the value from the POST request it will rely on the default which will be set to the correct value for each request by the code that calls it.

Change 805447 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Make 'Get edits' selected if 'Get IP Addresses' is used with an IP

https://gerrit.wikimedia.org/r/805447

Change 805447 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Make 'Get edits' selected if 'Get IP Addresses' is used with an IP

https://gerrit.wikimedia.org/r/805447

Dreamy_Jazz claimed this task.
Dreamy_Jazz moved this task from General / Unsorted to Done on the CheckUser board.

All the patches related to this have been merged, so this can be closed.