Page MenuHomePhabricator

Remove italics from the IP info legal disclaimer label
Closed, ResolvedPublic1 Estimated Story Points

Description

Italics doesn't work on many non-latin scripts (including CJK/Indic/Arabic scripts) and since we don't need any particular emphasis on this text we can remove it completely. The faux-italics that some browsers end up rendering doesn't make sense for those scripts.

AC

  • Legal disclaimer on the bottom right of the IP info box shouldn't be italicized

image.png (878×2 px, 142 KB)

Event Timeline

AGueyte set the point value for this task to 1.Jun 13 2022, 3:13 PM

Change 806284 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/IPInfo@master] Remove italic to infobox disclaimer

https://gerrit.wikimedia.org/r/806284

Change 806284 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Remove italic to infobox disclaimer

https://gerrit.wikimedia.org/r/806284

dom_walden subscribed.

Here is what is looks like on beta on the Vector 2022 skin in English:

removed_italics.png (293×1 px, 35 KB)

Notice that the Not Available is also in italics. @Prtksxna do we want that removed as well?

Notice that the Not Available is also in italics. @Prtksxna do we want that removed as well?

We want to keep the italics here, but yeah, it'll break in all the same ways as the legal disclaimer. There is a longer discussion that Thalia and I need to have around text emphasis in non-latin languages, will create relevant tickets once we do.

Notice that the Not Available is also in italics. @Prtksxna do we want that removed as well?

We want to keep the italics here, but yeah, it'll break in all the same ways as the legal disclaimer. There is a longer discussion that Thalia and I need to have around text emphasis in non-latin languages, will create relevant tickets once we do.

Thanks. I will move this into Done then.