Page MenuHomePhabricator
Create Task
Maniphest T309841

🟩️ Add POST /entities/items/{item_id}/statements endpoint to the OpenAPI spec
Closed, ResolvedPublic
Actions

Description

include:

  • request parameter `item_id: required
  • message body
    • statement: required
    • tags: default value []
    • bot: default value false
  • 201 happy response
    • Location, ETag and Last-Modified headers
  • 400, 404 and 500 error responses

out of scope for now:

  • authentication
  • redirect handling

cf. https://wmde.github.io/wikibase-rest-api-proposal/#/statements/post_entities__entity_type___entity_id__statements

Details

SubjectRepoBranchLines +/-
REST: Add Location header to statement responsemediawiki/extensions/Wikibasemaster+37 -1
REST: Specify creating an item statement via POSTmediawiki/extensions/Wikibasemaster+223 -84
Customize query in gerrit

Related Objects
Search...

Event Timeline

Silvan_WMDE created this task.Jun 3 2022, 9:54 AM
Silvan_WMDE claimed this task.Jun 3 2022, 10:48 AM
Silvan_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 7) board.
WMDE-leszek moved this task from Sprint 7 to Sprint 8 on the Wikibase Product Platform (v1) board.Jun 8 2022, 10:05 AM
WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 8); removed Wikibase Product Platform (v1) (Sprint 7).
WMDE-leszek moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 8) board.
gerritbot added a comment.Jun 8 2022, 1:45 PM

Change 803928 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Specify creating an item statement via POST

https://gerrit.wikimedia.org/r/803928

gerritbot added a project: Patch-For-Review.Jun 8 2022, 1:46 PM
Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 8) board.Jun 10 2022, 10:51 AM
Silvan_WMDE updated the task description. (Show Details)Jun 14 2022, 9:46 AM
gerritbot added a comment.Jun 14 2022, 10:05 AM

Change 803928 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Specify creating an item statement via POST

https://gerrit.wikimedia.org/r/803928

Maintenance_bot removed a project: Patch-For-Review.Jun 14 2022, 10:30 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jun 14 2022, 11:00 AM
Silvan_WMDE moved this task from Peer Review to Product Verification on the Wikibase Product Platform (v1) (Sprint 8) board.EditedJun 14 2022, 11:46 AM

@WMDE-leszek, Product Verification, please

see https://doc.wikimedia.org/Wikibase/master/js/rest-api/

WMDE-leszek added a comment.Jun 21 2022, 7:51 PM

Looks generally good, thank you!
Two remarks

  • should hash field of the mainsnak actually be part of the request? Or is it something left to Wikibase to generate?
  • thoughts on listing Location header in the 201 response headers? It is pretty standard one, so might be seen obvious and hence not needed to be included in the spec?
WMDE-leszek moved this task from Product Verification to Done on the Wikibase Product Platform (v1) (Sprint 8) board.Jun 22 2022, 10:04 AM
WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 9); removed Wikibase Product Platform (v1) (Sprint 8).Jun 22 2022, 10:07 AM
Ollie.Shotton_WMDE subscribed.Jun 23 2022, 11:39 AM

should hash field of the mainsnak actually be part of the request? Or is it something left to Wikibase to generate?

This is addressed in 807521 with Hash having the "readOnly": true property.

Silvan_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 9) board.Jun 24 2022, 8:35 AM
gerritbot added a comment.Jun 27 2022, 10:18 AM

Change 808851 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Add Location header to statement response

https://gerrit.wikimedia.org/r/808851

gerritbot added a project: Patch-For-Review.Jun 27 2022, 10:18 AM
Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 9) board.Jun 27 2022, 10:40 AM
gerritbot added a comment.Jun 29 2022, 10:18 AM

Change 808851 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add Location header to statement response

https://gerrit.wikimedia.org/r/808851

Maintenance_bot removed a project: Patch-For-Review.Jun 29 2022, 10:30 AM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 9) board.Jun 30 2022, 8:21 AM
WMDE-leszek closed this task as Resolved.Jul 11 2022, 9:18 AM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.21; 2022-07-18); removed MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jul 11 2022, 9:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits