Maniphest T309860

CheckComposerLockUpToDate fails when upgrading from MW 1.37.2 to 1.38.0
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Morn
	Jun 3 2022, 12:19 PM

Tags

Referenced Files

None

Subscribers

Description

I have encountered this problem on two MediaWiki installations on separate machines when upgrading from 1.37.2 to 1.38.0 using the official tarball: https://releases.wikimedia.org/mediawiki/1.38/mediawiki-1.38.0.tar.gz

Running php w/maintenance/update.php resulted in the following error:

MediaWiki 1.38.0 Updater

justinrainbow/json-schema: not installed, 5.2.11 required.
Error: your composer.lock file is not up to date. Run "composer update --no-dev" to install newer dependencies

This error should not occur, since justinrainbow/json-schema is included in MediaWiki and is also present in my file system. The update script terminates after this error without performing the necessary update operations.

The error message comes from maintenance/checkComposerLockUpToDate.php.

As a workaround, I have passed --skip-external-dependencies to w/maintenance/update.php. This allowed the update process to continue.

Information about my system:

Debian Linux 11.3
PHP 7.4.28
SQLite 3.34.1

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Installing justinrainbow/json-schema (5.2.11)	mediawiki/vendor	REL1_38	+5 K -3

Customize query in gerrit

Related Objects

Mentioned Here: T295175: Have at least one job running REL1_XX with its appropriate vendor repo
rMWf98f7312e1b1: SettingsBuilder: add ability to validate config against schema

Event Timeline

Morn created this task.Jun 3 2022, 12:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 3 2022, 12:19 PM

Mainframe98 merged a task: T309908: MediaWiki 1.38.0: Failure running maintenance/update.php due to justinrainbow/json-schema.Jun 4 2022, 6:31 AM

Mainframe98 added a project: MW-1.38-release.

Mainframe98 added a subscriber: Debo.

Bleugh.

rMWf98f7312e1b1: SettingsBuilder: add ability to validate config against schema promoted it from require-dev to require.

Yet another where T295175: Have at least one job running REL1_XX with its appropriate vendor repo would've helped.

Change 802884 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/vendor@REL1_38] Installing justinrainbow/json-schema (5.2.11)

https://gerrit.wikimedia.org/r/802884

gerritbot added a project: Patch-For-Review.Jun 4 2022, 7:44 AM

Change 802884 merged by Reedy:

[mediawiki/vendor@REL1_38] Installing justinrainbow/json-schema (5.2.11)

https://gerrit.wikimedia.org/r/802884

Maintenance_bot removed a project: Patch-For-Review.Jun 4 2022, 8:30 AM

TheresNoTime subscribed.Jun 4 2022, 11:21 AM

Dylsss merged a task: T309936: Fail to run update.php on 1.38.0: your composer.lock file is not up to date.Jun 5 2022, 5:11 AM

Dylsss added a subscriber: AdamMillerchip.

I'll get a 1.38.1 release out tomorrow.

Reedy closed this task as Resolved.Jun 6 2022, 1:39 PM

Reedy claimed this task.