Page MenuHomePhabricator
Create Task
Maniphest T309890

Latest comment indicator does not update when a new comment/topic is published
Closed, ResolvedPublic
Actions

Description

This task involves the work with making sure the latest comment indicator updates the moment an edit is published to a talk page.

Behavior

  1. Using the desktop or mobile version of the site, visit a talk page where the latest comment indicator is available. E.g. https://patchdemo.wmflabs.org/wikis/916be355b2/wiki/User_talk:Peter.
  2. Make an edit to the page using one of the following: A) the Reply Tool, B) the New Topic Tool, C) the 2010 wikitext editor
  3. Scroll the page such that the latest comment indicator is in view:

Screen Shot 2022-06-03 at 12.31.43 PM.png (704×1 px, 193 KB)

Actual

  1. ❗️Notice the latest comment indicator is NOT updated to reflect the edit you published in "3."

Desired

  1. ✅ The latest comment indicator IS updated to reflect the edit you published in "3."

Related Objects
Search...

Event Timeline

ppelberg created this task.Jun 3 2022, 7:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 3 2022, 7:33 PM
ppelberg added a parent task: T304372: [Release ticket] Deploy Page Frame as Beta Feature at Partner Wikis.Jun 3 2022, 7:34 PM
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.
Tacsipacsi subscribed.Jun 5 2022, 8:42 AM

I tested and it does work with the 2010 wikitext editor (since it reloads the whole page). It doesn’t work with the reply tool, though.

VPuffetMichel edited projects, added Editing-team; removed Editing-team (Kanban Board).Jun 6 2022, 7:30 PM
VPuffetMichel moved this task from Kanban Board to Needs Discussion / Investigation on the Editing-team board.
ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team.Jun 6 2022, 10:35 PM
ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.Jun 7 2022, 5:14 PM
Esanders subscribed.EditedJun 7 2022, 5:54 PM

This is fixed in the latest patchset. I noticed a separate issue we have with MediaWiki's relative timestamp format, which is that it doesn't make sense to use for second-accuracy, as signatures are rounded down to the nearest minute. For example, here I am told that the comment I just posted was posted 37 seconds ago:

image.png (128×498 px, 13 KB)

We should file this as a separate issue, it may be non-trivial to fix.

Edit: Filed as T310090

Esanders mentioned this in T310090: Relative timestamps have inappropriate accuracy for comment signatures.Jun 7 2022, 5:59 PM
ppelberg added a project: Goal.Jun 14 2022, 7:25 PM
Esanders moved this task from Ready to Be Worked On to Ready for Sign Off on the Editing-team (Kanban Board) board.Jun 15 2022, 2:37 PM
ppelberg closed this task as Resolved.Jul 8 2022, 12:57 AM
ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits