Page MenuHomePhabricator
Create Task
Maniphest T309919

Cavendish fatals on MW 1.38.0
Closed, InvalidPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Install MediaWiki 1.38.0
  • Install the skin
  • Attempt to use it then check the error log when it causes the wiki not to load at all

What happens?:
fatal below
2021-11-18 19:06:23: mod_fastcgi.c.487) FastCGI-stderr:PHP Fatal error: Cannot declare class SkinCavendish, because the name is already in use in /data/project/skins/public_html/skins/Cavendish/SkinCavendish.php on line 0

What should have happened instead?:

Works as expected without errors

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
PHP 7.4
MediaWiki 1.38.0
Latest version of Cavendish

Related Objects

Event Timeline

MacFan4000 created this task.Jun 4 2022, 2:16 PM
Restricted Application added a project: User-MacFan4000. · View Herald TranscriptJun 4 2022, 2:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MacFan4000 closed this task as Invalid.Jun 4 2022, 2:31 PM

sorry was looking at old logs. Is still broken though.

MacFan4000 reopened this task as Open.Jun 4 2022, 2:55 PM

found the current log and error is the same

ashley added subscribers: Jdlrobson, ashley.Jun 4 2022, 3:53 PM

Something doesn't add up here.

Latest version of Cavendish

@Jdlrobson removed the SkinCavendish class in 8e949f861d74e3d0cb07e41357385b3d7263eed5 (13 January 2022), which both GitHub's search as well as a local grep confirm -- there are no matches for "SkinCavendish" in master. So clearly you're using an older version. (The current master HEAD is 55a3e396999bd4c3422fa3f19d9e0883a67fb10d, committed on 18 February 2022; skin version 2.6.0.)

Are you using the correct, current, maintained one from WMF Gerrit (https://gerrit.wikimedia.org/g/mediawiki/skins/Cavendish/ rSCAV mediawiki-skins-Cavendish) as opposed to the legacy GitHub repo (https://github.com/DaSchTour/Cavendish) which was transferred to WMF Gerrit in January 2022?

MacFan4000 closed this task as Invalid.Jun 4 2022, 5:50 PM

Fixed by updating

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL