Page MenuHomePhabricator

Special:Nuke output parses [[:$1]] for a file as a link to $'"1 (that's single quote, then double)
Open, Needs TriagePublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Delete one or more files with [[Special:Nuke]] on a wiki (like enwiki) that includes the markup [[:$1]] in [[MediaWiki:Nuke-deleted]]

What happens?:

Superficially, the output is normal.

image.png (151×480 px, 22 KB)

However, if you click a link, it will take you to the page [[$'"1]] (single quote, then double), as can be seen in this HTML snippet

<ul>
<li>Page <b><a href="/w/index.php?title=$%27%221&amp;action=edit&amp;redlink=1" class="new" title="">File:Chiara Corbella Petrillo.png</a></b> has been deleted <span class="plainlinks">(<a href="/wiki/Special:Undelete/$%27%221" title="Special:Undelete/$'&quot;1">view</a> | <a class="external text" href="https://en.wikipedia.org/w/index.php?title=$%27%221&amp;action=protect">salt</a>)</span>.</li>
<li>Page <b><a href="/w/index.php?title=$%27%221&amp;action=edit&amp;redlink=1" class="new" title="$'&quot;1 (page does not exist)">File:Albertina Berkenbrock.png</a></b> has been deleted <span class="plainlinks">(<a href="/wiki/Special:Undelete/$%27%221" title="Special:Undelete/$'&quot;1">view</a> | <a class="external text" href="https://en.wikipedia.org/w/index.php?title=$%27%221&amp;action=protect">salt</a>)</span>.</li>
<li>Page <b><a href="/w/index.php?title=$%27%221&amp;action=edit&amp;redlink=1" class="new" title="">File:Elena Spirgevičiūtė.jpg</a></b> has been deleted <span class="plainlinks">(<a href="/wiki/Special:Undelete/$%27%221" title="Special:Undelete/$'&quot;1">view</a> | <a class="external text" href="https://en.wikipedia.org/w/index.php?title=$%27%221&amp;action=protect">salt</a>)</span>.</li>
<li>Page <b><a href="/w/index.php?title=$%27%221&amp;action=edit&amp;redlink=1" class="new" title="">File:Elena Spirgevičiūtė.png</a></b> has been deleted <span class="plainlinks">(<a href="/wiki/Special:Undelete/$%27%221" title="Special:Undelete/$'&quot;1">view</a> | <a class="external text" href="https://en.wikipedia.org/w/index.php?title=$%27%221&amp;action=protect">salt</a>)</span>.</li>
</ul>

I'm guessing that this is some sort of sanitization hypercorrection caused by @DannyS712's patch to my T304777? This does not happen when nuking pages other than files, as those now are unlinked (but still boldfaced) despite the attempt to make them linked in MediaWiki:Nuke-deleted on enwiki.

image.png (84×434 px, 7 KB)

Event Timeline

Change 803383 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/Nuke@master] Provide unescaped page title as the second param for messages

https://gerrit.wikimedia.org/r/803383

This comment was removed by Func.

Change 803383 merged by jenkins-bot:

[mediawiki/extensions/Nuke@master] SpecialNuke: Escape the page title for messages

https://gerrit.wikimedia.org/r/803383