Page MenuHomePhabricator

Improve Wikistories text display for readers and creators
Closed, ResolvedPublic

Assigned To
Authored By
SGautam_WMF
Jun 7 2022, 3:48 AM
Referenced Files
F35608130: Screen Shot 2022-10-21 at 9.38.05 AM.png
Oct 21 2022, 1:43 PM
F35592874: image.png
Oct 17 2022, 9:22 PM
F35592836: image.png
Oct 17 2022, 9:22 PM
F35592843: image.png
Oct 17 2022, 9:22 PM
F35494108: 03. Story viewer with no scroll.png
Aug 29 2022, 11:09 AM
F35494101: 03. Story builder with no scroll.png
Aug 29 2022, 11:09 AM
F35494089: 03. Story viewer text after scrolling.png
Aug 29 2022, 10:50 AM
F35494087: 03. Story viewer text before scrolling.png
Aug 29 2022, 10:50 AM

Description

Description/User story
Current default text boxCurrently creator's view after selecting textCurrently reader's view
Screenshot_20220607-093332_Chrome.jpg (2×1 px, 161 KB)
en.m.wikipedia.beta.wmflabs.org_wiki_Special_StoryBuilder_Story_Story_with_750_characters_frameid=0.png (1×720 px, 592 KB)
en.m.wikipedia.beta.wmflabs.org_wiki_Cat.png (1×720 px, 583 KB)

As a reader,
I want to view text on a wiki story, so that I can understand both the message and the image subject.

As a creator,
I want to add relevant text on a wiki story, so that I can curate a story around text that's readable and an image subject that's visible.

Design

Changes for story builder

Text box no scrollingText box when scrolling is available - before scrollText box when scrolling is available - after scrolling
03. Story builder with no scroll.png (780×360 px, 306 KB)
02. Story builder text box with scroll & fade.png (780×360 px, 296 KB)
02. Story builder text box with scroll & fade after scroll.png (780×360 px, 294 KB)
  • Increase empty text box size from 70px to 72px.
  • Change text box left and right margin from 18px to 16px.
  • Allow scrolling when story text is more than the maximum height of a text box.
  • Show a fade(blur) to communicate that there is more text to scroll.
  • Move fade position from bottom to top when no content is left to scroll up.
  • Don’t show the fade either top or bottom while user is scrolling the text.
  • Don't show the fade when text scrolling is not available.
  • Change textbox content padding from
padding: 10px 13px 10px 13px;

to

padding: 8px 20px 8px 8px;

Changes for story viewer

Text box no scrollingText box when scrolling is available - before scrollText box when scrolling is available - after scrolling
03. Story viewer with no scroll.png (780×360 px, 391 KB)
03. Story viewer text before scrolling.png (780×360 px, 384 KB)
03. Story viewer text after scrolling.png (780×360 px, 382 KB)
  • Allow scrolling when story text is more than the maximum height of a text box.
  • Show a fade(blur) to communicate that there is more text to scroll.
  • Don't show the fade when text scrolling is not available.
  • Once story text is scrolled, the page transition should freeze.
  • Change textbox content padding from
padding: 10px;

to

padding: 8px 20px 8px 8px;
  • Change textbox left and right margin

from

left: 20px;
right: 20px;

to

left: 16px;
right: 16px;

Note: We will experiment with different values of text box's height to find a working solution.

Design file

Acceptance criteria
  1. There should be a defined maximum height of the text area.
  2. Users should be able to scroll through text while viewing a story (there should be some indication of this being possible - a scroll bar?)
  3. Once story text is scrolled, the page transition should freeze.
  4. The user should be able to manually proceed to the previous/next story page.
Test scenarios
  1. Resize the screen width and ensure the text height remains constant.
  2. Browser compatibility testing.
Open questions

Event Timeline

SBisson edited projects, added Wikistories (R2); removed Wikistories (MVP).
SGautam_WMF renamed this task from Improve Wikistories text rendering to Improve Wikistories text display for readers and creators. .Aug 29 2022, 9:28 AM
SGautam_WMF updated the task description. (Show Details)
SGautam_WMF renamed this task from Improve Wikistories text display for readers and creators. to Improve Wikistories text display for readers and creators.Aug 29 2022, 10:01 AM
SGautam_WMF updated the task description. (Show Details)
SBisson triaged this task as Medium priority.Aug 30 2022, 2:24 PM

Change 830632 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/Wikistories@master] Improve wikistory text display

https://gerrit.wikimedia.org/r/830632

Change 836267 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/Wikistories@master] Merge branch 'T310038-text-display' into T310038-text-display-no-mixing

https://gerrit.wikimedia.org/r/836267

Change 830632 abandoned by Eamedina:

[mediawiki/extensions/Wikistories@master] Improve wikistory text display

Reason:

Opted for different approach, different patch

https://gerrit.wikimedia.org/r/830632

Change 836954 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/Wikistories@master] Improve wikistory text display per component approach

https://gerrit.wikimedia.org/r/836954

@SGautam_WMF the examples in the task description are missing one case: when the text is bigger than the textbox and it is currently scroll to the middle. In other words, there is more text available both above and below the text currently visible. In this case, should we show both faders?

@SGautam_WMF the examples in the task description are missing one case: when the text is bigger than the textbox and it is currently scroll to the middle. In other words, there is more text available both above and below the text currently visible. In this case, should we show both faders?

Thanks for sharing the case, we can skip showing fades for this case. We might consider it after testing it with different text lengths.

Change 836954 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Improve wikistory text display per component approach

https://gerrit.wikimedia.org/r/836954

@SBisson

  1. I presume the maximum height of the text box should be fixed across all devices? Below are screenshots of Safari v16 | Chrome v106 | Firefox v105. You can see that each viewport shows a different detail than the other, at maximum text box height.
image.png (1×798 px, 2 MB)
image.png (1×652 px, 1 MB)
image.png (1×888 px, 1 MB)
  1. This blurry feature does not show up at all on Firefox v105.0.1. The page transition does not freeze either.

@SBisson

  1. I presume the maximum height of the text box should be fixed across all devices? Below are screenshots of Safari v16 | Chrome v106 | Firefox v105. You can see that each viewport shows a different detail than the other, at maximum text box height.

It looks like those 3 screenshots have all different size and/or ratio. I just tried locally with Chrome and Firefox and they appeared identical to me.

Screen Shot 2022-10-21 at 9.38.05 AM.png (1×1 px, 1 MB)

  1. This blurry feature does not show up at all on Firefox v105.0.1. The page transition does not freeze either.

I have Firefox 106.0.1 and it works as expected. Can you try again and check for any javascript error in the console or anything special in your setup that might explain this?

  1. You were right. The height of my viewports were varying and thus, bits of the mountain top were showing. I ensured the heights of all browsers were the same and saw the same image.
  1. I tried this again and it worked. Really strange.

I will move this now.