Page MenuHomePhabricator

Deploy new toolbar order
Open, HighPublic2 Estimated Story Points

Description

Background

In T303549: Move titlebar above toolbar we moved the order of the tabs and title in the tool bar and continued with styling the toolbar in T309398: Article toolbar styling. These changes are feature flagged. We would like to deploy them together

Acceptance criteria

Event Timeline

Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Jdlrobson.

This is ready but now blocked on T309398 as well as design review of T309398.

Turn on for all wikis on Monday

Is this referring to Monday 20th? If so just noting that it is a WMF holiday

ovasileva renamed this task from Deploy new toolbar styling and order to Deploy new toolbar order.Wed, Jun 15, 4:57 PM
Jdlrobson updated the task description. (Show Details)

Change 808056 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable title above tabs on group 1 and group 0 wikis (1/2)

https://gerrit.wikimedia.org/r/808056

Change 808057 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable title above tabs on all opt-in wikis (2/2)

https://gerrit.wikimedia.org/r/808057

Change 808059 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Title should always be above tabs

https://gerrit.wikimedia.org/r/808059

@ppelberg we think deploying this is unblocked. I just wanted to confirm that you are okay with the plan in the task description before I execute it next week?

Jdlrobson updated the task description. (Show Details)

Change 808335 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Avoid bug when title below tabs at 1000px breakpoint with sidebar open

https://gerrit.wikimedia.org/r/808335

@ppelberg we think deploying this is unblocked. I just wanted to confirm that you are okay with the plan in the task description before I execute it next week?

@Jdlrobson: the plan in the task description looks good with one edit: can y'all please block the final deployment [i] on Editing QA confirming they have not discovered any urgent issues?

NOTE: @Ryasmeen + @EAkinloose, once you have completed QA of T310197, can you please comment as much on the task and ping @ovasileva and @Jdlrobson so they can know what – if any issues – the Web Team might need to address to unblock this task.

i. Turn on for all wikis in train commencing Monday 4th (assuming no problems with gadgets have been reported).

If I understand correctly, the editing QA only blocks deployment everyone, so I will push ahead tomorrow with the group 0 and group 1 deploy.

Change 808335 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Avoid bug when title below tabs at 1000px breakpoint with sidebar open

Reason:

Can't replicate now either, so that's good enough for me. Will restore if I see it again!

https://gerrit.wikimedia.org/r/808335

Change 808056 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable title above tabs on group 1 and group 0 wikis (1/2)

https://gerrit.wikimedia.org/r/808056

Mentioned in SAL (#wikimedia-operations) [2022-06-28T21:20:44Z] <cjming@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:808056|Enable title above tabs on group 1 and group 0 wikis (1/2) (T310054)]] (duration: 03m 34s)

This is now deployed on group 0 and group 1 wikis. Provided no new blockers surface we'll merge https://gerrit.wikimedia.org/r/c/808059 before next week's train. I've marked it as a train blocker.