Page MenuHomePhabricator
Create Task
Maniphest T310054

Deploy new toolbar order to everywhere except desktop improvements group 2 wikis
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Background

In T303549: Move titlebar above toolbar we moved the order of the tabs and title in the tool bar and continued with styling the toolbar in T309398: Article toolbar styling. These changes are feature flagged. We would like to deploy them together

Acceptance criteria

Details

SubjectRepoBranchLines +/-
Enable title above tabs on all opt-in wikis (2/2)operations/mediawiki-configmaster+1 -8
Layout: Title should always be above tabsmediawiki/skins/Vectormaster+1 -49
Vector: Deploy title above tabs to all opt-in wikisoperations/mediawiki-configmaster+15 -3
Vector: Deploy title above tabs to all opt-in wikisoperations/mediawiki-configmaster+22 -6
Enable title above tabs on group 1 and group 0 wikis (1/2)operations/mediawiki-configmaster+6 -0
Avoid bug when title below tabs at 1000px breakpoint with sidebar openmediawiki/skins/Vectormaster+5 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

ovasileva created this task.Jun 7 2022, 10:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 7 2022, 10:06 AM
ovasileva triaged this task as High priority.Jun 7 2022, 10:06 AM
ovasileva added a parent task: T301780: [Epic] Visual design & layout refinements.
ovasileva added a subtask: T303549: Move titlebar above toolbar.
Jdlrobson claimed this task.Jun 7 2022, 4:27 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson removed Jdlrobson as the assignee of this task.Jun 7 2022, 5:25 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson subscribed.
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 7 2022, 5:26 PM
LGoto set the point value for this task to 2.
Jdlrobson moved this task from Ready for Development to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 7 2022, 5:26 PM
Jdlrobson mentioned this in T303484: Introduce basic grid system to modern Vector.Jun 7 2022, 10:57 PM
Jdlrobson added a comment.Jun 8 2022, 11:35 PM

This is ready but now blocked on T309398 as well as design review of T309398.

Pcoombe subscribed.Jun 14 2022, 3:06 PM

Turn on for all wikis on Monday

Is this referring to Monday 20th? If so just noting that it is a WMF holiday

Jdlrobson updated the task description. (Show Details)Jun 14 2022, 3:56 PM
Jdlrobson claimed this task.Jun 15 2022, 4:41 PM
ovasileva renamed this task from Deploy new toolbar styling and order to Deploy new toolbar order.Jun 15 2022, 4:57 PM
Jdlrobson mentioned this in T310197: Move editing toolbar below page toolbar.Jun 15 2022, 10:58 PM
Jdlrobson moved this task from Blocked on Others to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 23 2022, 12:36 AM
Jdlrobson removed Jdlrobson as the assignee of this task.Jun 23 2022, 7:17 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Jun 23 2022, 7:23 PM

Change 808056 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable title above tabs on group 1 and group 0 wikis (1/2)

https://gerrit.wikimedia.org/r/808056

gerritbot added a project: Patch-For-Review.Jun 23 2022, 7:23 PM

Change 808057 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable title above tabs on all opt-in wikis (2/2)

https://gerrit.wikimedia.org/r/808057

gerritbot added a comment.Jun 23 2022, 7:23 PM

Change 808059 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Title should always be above tabs

https://gerrit.wikimedia.org/r/808059

Jdlrobson added a subscriber: • ppelberg.Jun 23 2022, 7:24 PM

@ppelberg we think deploying this is unblocked. I just wanted to confirm that you are okay with the plan in the task description before I execute it next week?

Jdlrobson updated the task description. (Show Details)Jun 23 2022, 8:28 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Jun 24 2022, 11:53 PM

Change 808335 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Avoid bug when title below tabs at 1000px breakpoint with sidebar open

https://gerrit.wikimedia.org/r/808335

• ppelberg added subscribers: EAkinloose, Ryasmeen.Jun 27 2022, 2:08 PM
In T310054#8024137, @Jdlrobson wrote:

@ppelberg we think deploying this is unblocked. I just wanted to confirm that you are okay with the plan in the task description before I execute it next week?

@Jdlrobson: the plan in the task description looks good with one edit: can y'all please block the final deployment [i] on Editing QA confirming they have not discovered any urgent issues?

NOTE: @Ryasmeen + @EAkinloose, once you have completed QA of T310197, can you please comment as much on the task and ping @ovasileva and @Jdlrobson so they can know what – if any issues – the Web Team might need to address to unblock this task.

i. Turn on for all wikis in train commencing Monday 4th (assuming no problems with gadgets have been reported).

Jdlrobson moved this task from Code Review to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 27 2022, 11:09 PM
Jdlrobson claimed this task.EditedJun 27 2022, 11:12 PM
Jdlrobson moved this task from Blocked on Others to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

If I understand correctly, the editing QA only blocks deployment everyone, so I will push ahead tomorrow with the group 0 and group 1 deploy.

Jdlrobson updated the task description. (Show Details)Jun 27 2022, 11:13 PM
gerritbot added a comment.Jun 27 2022, 11:17 PM

Change 808335 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Avoid bug when title below tabs at 1000px breakpoint with sidebar open

Reason:

Can't replicate now either, so that's good enough for me. Will restore if I see it again!

https://gerrit.wikimedia.org/r/808335

Agusbou2015 subscribed.Jun 28 2022, 6:14 PM
gerritbot added a comment.Jun 28 2022, 9:04 PM

Change 808056 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable title above tabs on group 1 and group 0 wikis (1/2)

https://gerrit.wikimedia.org/r/808056

Stashbot added a comment.Jun 28 2022, 9:20 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-28T21:20:44Z] <cjming@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:808056|Enable title above tabs on group 1 and group 0 wikis (1/2) (T310054)]] (duration: 03m 34s)

Jdlrobson moved this task from Doing to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 28 2022, 10:33 PM

This is now deployed on group 0 and group 1 wikis. Provided no new blockers surface we'll merge https://gerrit.wikimedia.org/r/c/808059 before next week's train. I've marked it as a train blocker.

Jdlrobson added a parent task: T308072: 1.39.0-wmf.19 deployment blockers.Jun 28 2022, 10:34 PM
gerritbot added a comment.Jun 30 2022, 4:12 PM

Change 810045 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Vector: Deploy title above tabs to all opt-in wikis

https://gerrit.wikimedia.org/r/810045

Jdlrobson removed Jdlrobson as the assignee of this task.Jun 30 2022, 7:20 PM
Jdlrobson moved this task from Blocked on Others to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Jun 30 2022, 8:45 PM

Change 810045 merged by jenkins-bot:

[operations/mediawiki-config@master] Vector: Deploy title above tabs to all opt-in wikis

https://gerrit.wikimedia.org/r/810045

gerritbot added a comment.Jun 30 2022, 9:07 PM

Change 810099 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Vector: Deploy title above tabs to all opt-in wikis

https://gerrit.wikimedia.org/r/810099

Jdlrobson updated the task description. (Show Details)Jun 30 2022, 9:09 PM

Since it's a new quarter: I moved the last bit of deployment into T311773

Jdlrobson moved this task from Code Review to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 30 2022, 10:07 PM
Jdlrobson moved this task from QA in Prod to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Jun 30 2022, 10:11 PM

Change 810099 merged by jenkins-bot:

[operations/mediawiki-config@master] Vector: Deploy title above tabs to all opt-in wikis

https://gerrit.wikimedia.org/r/810099

Stashbot added a comment.Jun 30 2022, 10:23 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-30T22:23:03Z] <cjming@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:810099|Vector: Deploy title above tabs to all opt-in wikis (T310054)]] (duration: 03m 36s)

Jdlrobson updated the task description. (Show Details)Jun 30 2022, 10:39 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

We are now live everywhere except group 2 desktop improvements wikis.
We'll deploy everywhere in T311773.

QA has happened elsewhere so this card skips QA.

ovasileva mentioned this in T311773: [Layout] Deploy title/tab order everywhere (Make it so that the title should always be above tabs).Jul 1 2022, 5:58 AM
Jdlrobson renamed this task from Deploy new toolbar order to Deploy new toolbar order to everywhere except desktop improvements group 2 wikis.Jul 1 2022, 3:08 PM
ovasileva closed this task as Resolved.Jul 4 2022, 7:24 AM
ovasileva claimed this task.

All done.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 4 2022, 7:24 AM
gerritbot added a comment.Jul 6 2022, 2:55 PM

Change 811734 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] [FIXMEs] Revise CSS that is no longer needed per FIXME guidelines

https://gerrit.wikimedia.org/r/811734

gerritbot added a comment.Jul 6 2022, 3:25 PM

Change 811734 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] [FIXMEs] Revise CSS that is no longer needed per FIXME guidelines

https://gerrit.wikimedia.org/r/811734

gerritbot added a comment.Jul 6 2022, 6:31 PM

Change 808059 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Layout: Title should always be above tabs

https://gerrit.wikimedia.org/r/808059

gerritbot added a comment.Jul 8 2022, 6:24 PM

Change 808057 abandoned by Jdlrobson:

[operations/mediawiki-config@master] Enable title above tabs on all opt-in wikis (2/2)

Reason:

Done in I7733069ef7d9a1b76bcbba20ce26b152068a0036

https://gerrit.wikimedia.org/r/808057

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 3:01 AM
Esanders subscribed.Jul 18 2022, 4:42 PM

When removing a config don't forget to grep for users:

https://codesearch.wmcloud.org/search/?q=VectorTitleAboveTabs&i=nope&files=&excludeFiles=&repos=

Jdlrobson added a comment.EditedJul 18 2022, 4:59 PM
In T310054#8085176, @Esanders wrote:

When removing a config don't forget to grep for users:

https://codesearch.wmcloud.org/search/?q=VectorTitleAboveTabs&i=nope&files=&excludeFiles=&repos=

I'll be cleaning that up tomorrow when we deploy the grid. Patch later today. See also T311773.
EDIT: See https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/814869

ovasileva removed a subtask: T303549: Move titlebar above toolbar.Sep 13 2022, 12:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL