Update error message on blur of Lookup where no item has been selected
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	guergana.tzatchkova
	Jun 8 2022, 10:32 AM

Description

List of steps to reproduce (step by step, including full links if applicable):

Fill out a lookup field with some text, and then press the Tab key. Make sure to not choose one of the menu items options
Click the Create Lexeme button

What happens?:

There's an error message shown below the lookup that says that the lookup is empty. The Lookup is technically not empty so this message needs to be changed to "invalid entry" probably. Screenshot below.

What should have happened instead?:

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Details

	Subject	Repo	Branch	Lines +/-
	build changes from to new-lexeme	mediawiki/extensions/WikibaseLexeme	master	+4 -4
	Lexidata: add invalid content error message keys	mediawiki/extensions/WikibaseLexeme	master	+9 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	guergana.tzatchkova	T201587 Audit keyboard navigation on Special:NewLexeme
Resolved	Lydia_Pintscher	T305854 Per-field inline validation and error messages for invalid input in lemma, language, spelling variant or lexical category field
Resolved	Lydia_Pintscher	T310134 Update error message on blur of Lookup where no item has been selected

Event Timeline

guergana.tzatchkova created this task.Jun 8 2022, 10:32 AM

@Lydia_Pintscher We need copy for this type of error message, where the entry is not an item and therefore invalid. any Ideas?

How about these?

"Lexeme language needs to be a valid Item."
"Spelling variant needs to be a valid language code."
"Lexical category needs to be a valid Item."

noarave moved this task from To Do to Doing on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 9) board.Jun 10 2022, 8:32 AM

Change 804571 had a related patch set uploaded (by Noa wmde; author: Noa wmde):

[mediawiki/extensions/WikibaseLexeme@master] Lexidata: add invalid content error message keys

https://gerrit.wikimedia.org/r/804571

gerritbot added a project: Patch-For-Review.Jun 10 2022, 12:43 PM

https://github.com/wmde/new-lexeme-special-page/pull/223

Here’s what it looks like with the current state of the pull request:

The “no results” covers the error message while the input is focused. Is that okay?

Lydia_Pintscher mentioned this in T305854: Per-field inline validation and error messages for invalid input in lemma, language, spelling variant or lexical category field.Jun 13 2022, 9:10 AM

Lydia_Pintscher added a parent task: T305854: Per-field inline validation and error messages for invalid input in lemma, language, spelling variant or lexical category field.

Yes.

karapayneWMDE moved this task from Special:NewLexeme revival - sprint 9 to Special:NewLexeme revival - sprint 10 on the Special:NewLexeme revival board.Jun 14 2022, 8:39 AM

karapayneWMDE edited projects, added Special:NewLexeme revival (Special:NewLexeme revival - sprint 10); removed Special:NewLexeme revival (Special:NewLexeme revival - sprint 9).

karapayneWMDE moved this task from To Do to Doing on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.

noarave moved this task from Doing to Peer Review on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.Jun 15 2022, 8:20 AM

Lucas_Werkmeister_WMDE changed the subtype of this task from "Bug Report" to "Task".Jun 15 2022, 10:54 AM

Change 804571 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Lexidata: add invalid content error message keys

https://gerrit.wikimedia.org/r/804571

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jun 15 2022, 2:00 PM

noarave moved this task from Peer Review to Test (Verification) on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.Jun 16 2022, 8:52 AM

I think this still needs an update in WikibaseLexeme.git?

Change 806204 had a related patch set uploaded (by Noa wmde; author: Noa wmde):

[mediawiki/extensions/WikibaseLexeme@master] build changes from to new-lexeme

https://gerrit.wikimedia.org/r/806204

noarave moved this task from Test (Verification) to Peer Review on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.Jun 16 2022, 12:12 PM

Change 806204 merged by jenkins-bot: