| awight | |
| Jun 8 2022, 10:43 AM |
| F35218303: image.png | |
| Jun 8 2022, 10:43 AM |
List of steps to reproduce (step by step, including full links if applicable):
What happens?:
The parameter description is selected, but not the title:
What should have happened instead?:
Should have selected the title and not the description.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix parameter labels not being clickable | mediawiki/extensions/VisualEditor | master | +2 -3 |
A solution for this exists as a side-effect in patch https://gerrit.wikimedia.org/r/804576. Unfortunately we never merged that patch for other reasons.
The issue appears to be related to collapsible descriptions. It does not only block double and tripple clicks, but also single clicks. A single click should put the focus in the input field. I found a float: left in the code that appears to be misplaced. Probably a now unused fragment from the old design. When I remove this it works as it should.
Change 827519 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/VisualEditor@master] Fix parameter labels not being clickable
Change 827519 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix parameter labels not being clickable