Page MenuHomePhabricator
Create Task
Maniphest T310153

Validate URLs for WikispeechSpeechoidHaproxyQueueUrl and WikispeechSymbolSetUrl
Open, Needs TriagePublic
Actions

Description

The config variables for WikispeechSpeechoidHaproxyQueueUrl and WikispeechSymbolSetUrl are required for listening and editing lexicon respectively. There should be a check that they are set. For WikispeechSpeechoidUrl this is done in ApiHooks:validateConfiguration.

Event Timeline

Sebastian_Berlin-WMSE created this task.Jun 8 2022, 1:13 PM
Restricted Application added a project: Wikispeech-Jobrunner. · View Herald TranscriptJun 8 2022, 1:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Sebastian_Berlin-WMSE updated the task description. (Show Details)Oct 9 2024, 8:10 AM
Sebastian_Berlin-WMSE moved this task from Incoming to Backlog on the Wikispeech-Jobrunner board.Feb 27 2025, 1:04 PM
Sebastian_Berlin-WMSE added a project: Wikispeech-WMSE.

WikispeechSpeechoidHaproxyQueueUrl isn't needed. In fact it doesn't even seem to be used? You can still look up entries without WikispeechSymbolSetUrl, so maybe there should be an error on preview or save.

Sebastian_Berlin-WMSE added a comment.Tue, Sep 15, 7:50 AM
In T310153#10586692, @Sebastian_Berlin-WMSE wrote:

WikispeechSpeechoidHaproxyQueueUrl isn't needed. In fact it doesn't even seem to be used?

This was wrong. It's used in SpeechoidConnector::synthesize()

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits