Page MenuHomePhabricator
Create Task
Maniphest T310188

Due Date stamp rendering requires "deadline" task subtype; does not show for other task subtypes though Due Date field is filled
Open, LowPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • T279593 uses Form 3 (which can be revealed by editing the task, clicking "Configure Form" and choosing, "Edit Form Configuration")
  • The Due Date field is checked, with a date assigned
  • As far as I can tell, the affected task is Form 3, but most Deadline tasks (those with Due Date) are Form 54. I wonder if Form 3 did not originally have Due Date and the Form configuration was edited after this task was created.

What happens?:
As you can see on these screenshots, the first task does not get a stamp while the second does, despite both having a Due Date field filled (the second screenshot is the first task being edited, to show the Due Date field).

image.png (442×682 px, 155 KB)

image.png (1×1 px, 382 KB)

What should have happened instead?:

  • The stamp should appear on board views (the task is, as of this writing, only tagged on private boards, but the task is public and can be tagged onto other boards for testing)

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

  • Firefox 101.0, Chrome 102.0.5005.61

Related Objects

Event Timeline

MBinder_WMF created this task.Jun 8 2022, 3:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2022, 3:08 PM
MBinder_WMF mentioned this in T279593: Request from Desiree: Dev skills survey to determine who has which skills.Jun 8 2022, 3:09 PM
Aklapper mentioned this in T311168: Some deadline stamps change color, while others do not, despite having the same deadline.Jul 1 2022, 11:04 AM

See also T311168: Some deadline stamps change color, while others do not, despite having the same deadline

RhinosF1 subscribed.Jun 8 2023, 4:42 PM
Aklapper added a comment.Jun 9 2023, 2:41 PM

Found the code in https://phabricator.wikimedia.org/source/phab-extensions/browse/wmf%252Fstable/src/customfields/DeadlineEditEngineSubtype.php .

Looking at this custom code, the stamp rendering relies on the task subtype being "deadline".
(I don't know why it was implemented like and I don't like this - a bug report should have a bug subtype and not a deadline subtype, as I wrote in T335395).

Data agrees:

mysql:phstats@m3-slave.eqiad.wmnet [phabricator_maniphest]> SELECT id, subtype FROM maniphest_task WHERE (id = 279593 OR id = 298661);
+--------+----------+
| id     | subtype  |
+--------+----------+
| 279593 | default  |
| 298661 | deadline |
+--------+----------+
2 rows in set (0.001 sec)
Aklapper renamed this task from Due Date stamp doesn't show on a Phab task even though the field is filled to Due Date stamp rendering requires "deadline" task subtype; does not show for other task subtypes though Due Date field is filled.Jun 9 2023, 2:41 PM
Aklapper mentioned this in T335395: Remove "Deadline" task subtype.Jun 9 2023, 5:20 PM
valerio.bozzolan subscribed.Jun 20 2023, 10:58 AM
Aklapper moved this task from To Triage to Needs code (in Phab or bot) on the Phabricator board.Jul 12 2023, 8:10 PM
Aklapper triaged this task as Low priority.Jul 13 2023, 5:50 PM
Aklapper mentioned this in T355307: Show deadline task's due time on workboard card.Mar 17 2024, 3:49 PM
Aklapper mentioned this in T379376: Weird indentation on task list (due to empty rendering of deadline subtype tag).Nov 18 2024, 3:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits