NOTE: before estimation clarify in acceptance criteria 1) whether this should be for all skins or just Vector AND 2) Whether the WikimediaEvents max-snippets A/B test code can safely be removed (if retained it could clash with this in future)

@ovasileva during estimation the question was asked whether this should be all skins or just Vector (if so which Vector(s)?)

In T310267#8283977, @Jdlrobson wrote:

NOTE: before estimation clarify in acceptance criteria 1) whether this should be for all skins or just Vector AND 2) Whether the WikimediaEvents max-snippets A/B test code can safely be removed (if retained it could clash with this in future)

@ovasileva during estimation the question was asked whether this should be all skins or just Vector (if so which Vector(s)?)

What are the implications for implementing it across all skins? Generally, I think Vector and Vector 2022 should be included, although I have no issues with implementing it across all skins if that's easier.

Change 838739 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/core@master] Allow large image previews by adding max image preview tag

https://gerrit.wikimedia.org/r/838739

Change 838790 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/core@master] Allow large image previews by adding max image preview tag

https://gerrit.wikimedia.org/r/838790

Change 838790 abandoned by Mabualruz:

[mediawiki/core@master] Allow large image previews by adding max image preview tag

Reason:

https://gerrit.wikimedia.org/r/838790

In T310267#8288211, @Jdlrobson wrote:

@ovasileva does this need to be feature flagged or can it just go out everywhere (which is what Mo's patch does)?
” Study effects of large image meta tag and ensure it does not introduce any unintended limitations” implies some kind of testing.

No A/B test will be necessary in this case, this will be observational. We will look at pageviews across various wikis after the change is deployed

We also have A/B test code for max-snippet - can that be removed now or was the intention that this code would replace it?
https://gerrit.wikimedia.org/g/mediawiki/extensions/WikimediaEvents/+/38c977d447292535a256eb7b360ad41632797f9d/includes/PageSplitter/PageSplitterHooks.php#73

We can remove the A/B testing code

Change 838739 merged by jenkins-bot:

[mediawiki/core@master] Allow large image previews by adding max image preview tag

https://gerrit.wikimedia.org/r/838739

In T310267#8288370, @gerritbot wrote:

Change 838739 merged by jenkins-bot:

[mediawiki/core@master] Allow large image previews by adding max image preview tag

https://gerrit.wikimedia.org/r/838739

FYI, this has broken a test in ArticlePlaceholder, which blocks CI for Wikibase and other extensions. I’d appreciate some assistance at T319518 – I see that this change includes a diff that seems relevant to that test failure:

diff --git a/tests/phpunit/includes/OutputPageTest.php b/tests/phpunit/includes/OutputPageTest.php
index 55542a3f7a..6c0b7dcc71 100644
--- a/tests/phpunit/includes/OutputPageTest.php
+++ b/tests/phpunit/includes/OutputPageTest.php
@@ -233,7 +233,7 @@ public function testMetaTags() {
         $this->assertContains( '<meta name="keywords" content="first"/>', $links );
         $this->assertContains( '<meta name="keywords" content="second"/>', $links );
         $this->assertContains( '<meta property="og:title" content="Ta-duh"/>', $links );
-        $this->assertArrayNotHasKey( 'meta-robots', $links );
+        $this->assertArrayHasKey( 'meta-robots', $links );
     }

But I have no idea if this is correct or not, or why this meta name should now change.

In T310267#8289884, @Lucas_Werkmeister_WMDE wrote:

In T310267#8288370, @gerritbot wrote:

Change 838739 merged by jenkins-bot:

[mediawiki/core@master] Allow large image previews by adding max image preview tag

https://gerrit.wikimedia.org/r/838739

FYI, this has broken a test in ArticlePlaceholder, which blocks CI for Wikibase and other extensions. I’d appreciate some assistance at T319518 – I see that this change includes a diff that seems relevant to that test failure:

diff --git a/tests/phpunit/includes/OutputPageTest.php b/tests/phpunit/includes/OutputPageTest.php
index 55542a3f7a..6c0b7dcc71 100644
--- a/tests/phpunit/includes/OutputPageTest.php
+++ b/tests/phpunit/includes/OutputPageTest.php
@@ -233,7 +233,7 @@ public function testMetaTags() {
         $this->assertContains( '<meta name="keywords" content="first"/>', $links );
         $this->assertContains( '<meta name="keywords" content="second"/>', $links );
         $this->assertContains( '<meta property="og:title" content="Ta-duh"/>', $links );
-        $this->assertArrayNotHasKey( 'meta-robots', $links );
+        $this->assertArrayHasKey( 'meta-robots', $links );
     }

But I have no idea if this is correct or not, or why this meta name should now change.

Thanks for the fix, I added a default value [ 'max-image-preview' => 'standard' ] to robotOptions, and that effected somehow the meta-robots key, I adjusted tests to best of my knowledge to cover the new cases. If you have an idea of why this key 'meta-robots' stopped showing I am also wondering how

Change 839608 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/WikimediaEvents@master] Allow large image previews by adding max image preview tag

https://gerrit.wikimedia.org/r/839608

Change 839608 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Remove A/B test: Allow large image previews

https://gerrit.wikimedia.org/r/839608

Edward please can we verify that the meta robots tag is present in article HTML and contains the max-image-preview meta information?

Did this actually do anything? The linked documentation seems to imply that max-image-preview: standard is the default, so just sending that tag on every page should have no effect.

From the task description:

https://developers.google.com/search/case-studies/large-images-case-study?hl=en

That page suggests sending max-image-preview: large, which enables large image previews. Sending max-image-preview: standard does not enable large image previews.