Next: Icon: representing what project the person is on

This may be a solved problem depending on where the data related work of this ticket lands, but currently I'm unclear about where this icon asset actually originates from (API side/or completely locally).

@Dmantena sorry for my forgetting, but how did we assign icons for different projects in the notifications feature?

In T310273#8105817, @cmadeo wrote:

@Dmantena sorry for my forgetting, but how did we assign icons for different projects in the notifications feature?

@cmadeo No worries! For notifications, we bundled local image assets into the app for these (and only these) projects:

.commons: return "notifications-project-commons"
.wikidata: return "notifications-project-wikidata"
.wikiquote: return "notifications-project-wikiquote"
.wikibooks: return "notifications-project-wikibooks"
.wiktionary: return "notifications-project-wiktionary"
.wikisource: return "notifications-project-wikisource"
.wikinews: return "notifications-project-wikinews"
.wikiversity: return "notifications-project-wikiversity"
.wikivoyage: return "notifications-project-wikivoyage"
.mediawiki: return "notifications-project-mediawiki"
.wikispecies: return "notifications-project-wikispecies"

It's unclear to me if these existing local image assets sufficiently cover our needs here or not.

@Dmantena thanks for letting me know! Yes, I believe this should cover our needs here :)

Hi @Deepak! I am following up after Thursday's meeting, here are some of the suggestions for the header:

• Header padding (top & bottom 12 pts, left & right 16 pts)
• Min. height of header will be 106 pts
• Title truncates after 4 lines
• Thumbnail image stays 80 x 80 pts and sticks to the top of the header.
  • Keeping thumbnail square to keep consistency throughout the app.

Current header example	Suggestions applied to another article talk page	Eg. of minimal height	Eg. of maximum title length

PR up at: https://github.com/wikimedia/wikipedia-ios/pull/4287. Actual data will be filled from forthcoming talk page data controller work, and coffee roll background color will need to be updated post color guide finalization (https://phabricator.wikimedia.org/T299793).

See this comment for an update on connecting this header view to live data. Once both parts of this are merged (and coffee roll color is finalized), we'll move this task to Needs QA.

Project icon & routing portion of this is in my court, so assigning myself.

Things remaining to develop:

Supporting routing & icon display from other projects besides Wikipedia

https://github.com/wikimedia/wikipedia-ios/pull/4337

Waiting for code review until 6.9.3 is out.

Hi @OTichonova! We have another question for you for the User talk header.

For Wikipedia projects, do you want us to display some sort of Wikipedia icon, along with the language indicator, or do you want the project icon to be hidden? I notice your mock has a MediaWiki icon, which threw us off a bit because that project isn't language-specific. Let me know if these assumptions are right/wrong:

1. For Wikipedia language project, show only the language indicator
2. For other language-specific project (Spanish Wikinews, etc.), show project icon & language indicator
3. For non-language-specific projects (MediaWiki, Commons, Wikidata, etc.), show only the project icon

@OTichonova Update: Or maybe MediaWiki is language-specific? 😅 It seems constructed differently than other language-specific projects (no language subdomain). For Notifications Center we did not give it any language-specific treatment/considerations, and the Notifications API identifies it as one project.

Hi @Tsevener,
Sorry for the confusion! I forgot that on MediaWiki one changes the language differently from Wikipedia.
Yes, these assumptions are correct.

For Wikipedia language project, show only the language indicator
For other language-specific project (Spanish Wikinews, etc.), show project icon & language indicator
For non-language-specific projects (MediaWiki, Commons, Wikidata, etc.), show only the project icon

I was trying to test talk pages on MediaWiki and wanted to clarify. When someone receives a talk page message on their MediaWiki account -> they tap on their notification -> then tap to 'Your talk page' from notifications, will they see the native designs we are working on?
Thanks!

I was trying to test talk pages on MediaWiki and wanted to clarify. When someone receives a talk page message on their MediaWiki account -> they tap on their notification -> then tap to 'Your talk page' from notifications, will they see the native designs we are working on?

Good question - I did some digging on this and it looks like MediaWiki uses Flow, which the discussion tools API does not support:

https://www.mediawiki.org/wiki/Structured_Discussions/Wikis

So MediaWiki notifications will continue to open in web. We structured things generically enough so that as long as notifications contain URLs with the structure {host}/wiki/Talk:{title} or {host}/wiki/User_talk:{username}, and the host is one of the recognized Wikimedia projects from the notifications feature, it will open up our new native view. It looks like MediaWiki notifications currently contain url structures like: https://www.mediawiki.org/wiki/Topic:X4xbflraprh8xm3y?markasread=1624272&markasreadwiki=mediawikiwiki because of Flow - which the app doesn't recognize - so it sends them to a web view.

Hi @Tsevener! It looks like in the current implementation the minimum padding between the Title and the image thumbnail might be smaller than @OTichonova designed (it should be 12pts)

Design review PR - https://github.com/wikimedia/wikipedia-ios/pull/4380

Appears to be working on 7.0.0 (2005)