Per planning yesterday - we're not going to make the theming / font size popover for V1. Since this is a native screen, the expectation is for this screen to work with Apple's dynamic type system setting, not the article/editor web view text size.

PR https://github.com/wikimedia/wikipedia-ios/pull/4305

Things remaining to develop:

Need button functionality on all of these

Pushing to revision history PR - https://github.com/wikimedia/wikipedia-ios/pull/4344

Things remaining to develop:

Find in page

Moving to waiting while Find in Page is developed (T319470).

Hey @OTichonova! Can you confirm the 1. background color and 2. theme element we should be using for the highlighted background shown here? https://phab.wmfusercontent.org/file/data/3nhdayomawj2dopfdjst/PHID-FILE-top6xydb3q2qiobmewwi/Search_primate_.png

Hi @Dmantena!

1. Sorry, just to clarify, which background color are you referring to? The background color of the keyboard (should be the same as in 'find in page' on the article page)? The page background color behind the cells (it is #F8F9FA)?
2. Just to clarify, what is a theme element? The color of the highlighted background (should be the same as in the 'find in page' on the article page #FFCC33/color-yellow-600).

1. Sorry, just to clarify, which background color are you referring to?

@OTichonova Apologies - I was referring to the find in page highlighted background color.

2. Just to clarify, what is a theme element?

Meaning which existing semantic element name (baseBackground, midBackground, overlayText, etc.) in our existing Theme colors should we be using for this find in page background color. I don't see one element that maps to yellow50 aka #FFCC33 across all our themes.

Hi @Dmantena!
Ahhh I see, thank you. so much for all the clarification.
So I am digging around for it and I think it is actually Yellow50.
I found it with -->
descriptionBackground: .yellow50,
warning: .yellow50
descriptionWarning: .yellow50

@OTichonova No worries - sorry, I should have been more clear! Indeed you're right we use yellow50 as a value in app for different UI elements, but it doesn't seem like we have one specific semantic theme element (e.g. baseBackground, warning, etc.) that maps to using yellow50 as the value for each theme (light, dark, black, sepia).

The way it's engineered in app is that we choose a theme's general semantic element name to use for a UI element, and then as the user changes between themes the app then automatically selects the appropriate color to display. So as an example, we may set the background color for a view to the semantic theme element baseBackground. In the light theme, the color value of this is currently set to base80 / #EAECF0. But if the user changes their app theme to Sepia, this background color is set to the value sepiaBase85/ #E1DAD1.

So on the engineering side, we need an existing semantic element name (warning, unselected, shadow, etc.) to use to set as the background color for the find in page highlight, which will automatically select an appropriate actual value based on the user's selected theme.

There doesn't seem to to be one semantic theme element name that maps to the value yellow50 for all themes, so if you don't see a semantic name that works for our purposes, lemme know and I can just special case use yellow50 regardless of user's theme (similar to the special casing I did for the coffee roll background color, which we also didn't have a usable semantic element for).

Hi @Dmantena,
Right! I am with you now, sorry for taking so long to understand the ask.

I looked at the articles find in page (shown below). It seems like there is another color used for dark & black themes that I can't find anywhere. I think keeping it Yellow50 for all themes is fine.
Additionally, like in the example below, it would be great to revert the color of the highlighted word for the dark and black themes as done in the article view.
Eg. so for the dark/black themes, the word 'plan' is black, while the rest of the words on the page are a very light gray/almost white color. This will help to keep the necessary contrast between the word and the Yellow50 highlight. Do you think that is okay to implement?

Default	Sepia	Dark	Black

Right! I am with you now, sorry for taking so long to understand the ask.

No worries at all!

I looked at the articles find in page (shown below). It seems like there is another color used for dark & black themes that I can't find anywhere. I think keeping it Yellow50 for all themes is fine.

Sounds good.

Additionally, like in the example below, it would be great to revert the color of the highlighted word for the dark and black themes as done in the article view.
Eg. so for the dark/black themes, the word 'plan' is black, while the rest of the words on the page are a very light gray/almost white color. This will help to keep the necessary contrast between the word and the Yellow50 highlight. Do you think that is okay to implement?

Great call out, I'll be sure this is reflected in the work.

Find in page part 1: https://github.com/wikimedia/wikipedia-ios/pull/4355
Find in page part 2: https://github.com/wikimedia/wikipedia-ios/pull/4376
Find in page part 3: https://github.com/wikimedia/wikipedia-ios/pull/4393

Just a heads up, I'm keeping the find-in-page subtask (T319470) in Ready for Dev, because it still has some missed scrolling moments. But I think enough of it is in place to begin design reviewing and testing.

Hi!
When testing I noticed two things:

1. Under 'Share' the airdrop option for some reason doesn't open the talk page but opens a warning message instead (for en talk pages and other languages). Sending the link via email or what's app worked.

Message when airdropping talk page (mobile)	Web

2. I am aware that the 'Find in Page' is still being worked on, but I wanted to throw in an example that I found where the screen didn't scroll at all, in the recording I keep tapping on the down arrow to show the next result, but the screen stays completely still (WWII talk page). Watch screen recording here

PR for the broken shared links https://github.com/wikimedia/wikipedia-ios/pull/4397

This will be ready to test in TestFlight build 7.0.0 (2010).

Working for me on 7.0.0 (2010)